Bug 20238 – Minor bugs with style editing in the Inspector

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Timothy Hatcher]

The scroll position stays where it was when editing a string that was longer than the editing input area.

The text shifts when entering and exiting editing mode.

Child elements are sometimes not restored for shorthands.

Shorthands are not always expanded again after editing.

Color swatches should be hidden when editing.

[Adam Roben (:aroben)]

Maybe we should have separate bugs for each of these issues?

[Timothy Hatcher]

Created attachment 22572 [details]
Proposed patch

[Adam Roben (:aroben)]

Comment on attachment 22572 [details]
Proposed patch

-        // Lie about out children to prevent toggling on click.
+        this.wasExpanded = this.expanded;
+
+        // Lie about our children to prevent expanding on double click and to collapse shorthands.
+        this.reallyHasChildren = this.hasChildren;
         this.hasChildren = false;
 
         if (!selectElement)
@@ -563,23 +564,26 @@ WebInspector.StylePropertyTreeElement.prototype = {
 
         window.getSelection().setBaseAndExtent(selectElement, 0, selectElement, 1);
 
-        WebInspector.startEditing(this.listItemElement, this.editingCommitted.bind(this), this.editingCancelled.bind(this), wasExpanded);
+        WebInspector.startEditing(this.listItemElement, this.editingCommitted.bind(this), this.editingCancelled.bind(this));

I guess you could pass the information along in the context parameter to startEditing instead of storing it on this. That would save you from having to delete the properties later. But it doesn't matter too much either way.

r=me!

[Adam Roben (:aroben)]

Oh, don't forget to mention the bug number in the URL.

[Timothy Hatcher]

Landed in r35472.