Bug 202378

Summary: LayoutTests, contentSecurityPolicy: Avoid using timeout as a failure mode
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED WONTFIX    
Severity: Normal CC: dbates, ews-watchlist, mkwst
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jonathan Bedard
Reported 2019-09-30 15:50:20 PDT
Timeouts are very expensive for layout tests. We should try and avoid using them as a failure mode. Most contentSecurityPolicy tests attach an event listener to securitypolicyviolation and only end the test if that listener is triggered, this means that if the tests fail, they timeout.
Attachments
Patch (1.45 KB, patch)
2019-09-30 15:53 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2019-09-30 15:53:37 PDT
Created attachment 379849 [details] Patch
Jonathan Bedard
Comment 2 2019-09-30 16:00:59 PDT
Comment on attachment 379849 [details] Patch Let's see what EWS says...this has the potential to make tests flakey, if the securitypolicayviolation is triggered asynchronously. Local testing indicated that it's not, but I didn't test everything.
Jonathan Bedard
Comment 3 2019-10-01 08:19:05 PDT
This is a bad idea, it definitely causes flakiness.
Note You need to log in before you can comment on or make changes to this bug.