Bug 202358

Summary: [Nicosia] Complete ScrollingTreeNicosia::createScrollingTreeNode()
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, cmarcelo, ews-watchlist, fred.wang, jamesr, luiz, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 198475    
Attachments:
Description Flags
Patch
none
Patch for landing none

Zan Dobersek
Reported 2019-09-29 22:49:03 PDT
[Nicosia] Complete ScrollingTreeNicosia::createScrollingTreeNode()
Attachments
Patch (2.58 KB, patch)
2019-09-29 22:50 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.47 KB, patch)
2019-09-30 02:03 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2019-09-29 22:50:27 PDT
Created attachment 379823 [details] Patch
Carlos Garcia Campos
Comment 2 2019-09-30 01:04:51 PDT
Comment on attachment 379823 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379823&action=review > Source/WebCore/page/scrolling/nicosia/ScrollingTreeNicosia.cpp:74 > - RELEASE_ASSERT_NOT_REACHED(); > + ASSERT_NOT_REACHED(); > + return ScrollingTreeFixedNode::create(*this, nodeID); why?
Zan Dobersek
Comment 3 2019-09-30 02:03:24 PDT
Created attachment 379829 [details] Patch for landing
Zan Dobersek
Comment 4 2019-09-30 02:06:40 PDT
Comment on attachment 379829 [details] Patch for landing Clearing flags on attachment: 379829 Committed r250514: <https://trac.webkit.org/changeset/250514>
Zan Dobersek
Comment 5 2019-09-30 02:06:44 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-09-30 02:07:20 PDT
<rdar://problem/55832537>
Note You need to log in before you can comment on or make changes to this bug.