Bug 202351

Summary: [LFC][IFC] Move horizontal alignment to Line
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

alan
Reported 2019-09-28 13:18:57 PDT
Line should finalize the runs including horizontal alignment
Attachments
Patch (19.83 KB, patch)
2019-09-28 13:26 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (23.04 KB, patch)
2019-09-28 13:40 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (23.04 KB, patch)
2019-09-28 17:57 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-09-28 13:19:15 PDT
<rdar://problem/55810139>
alan
Comment 2 2019-09-28 13:26:27 PDT
Created attachment 379794 [details] Patch
alan
Comment 3 2019-09-28 13:40:25 PDT
Created attachment 379795 [details] Patch
Antti Koivisto
Comment 4 2019-09-28 14:20:58 PDT
Comment on attachment 379795 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379795&action=review > Source/WebCore/layout/inlineformatting/InlineLine.cpp:60 > +Line::Line(const InlineFormattingContext& inlineFormattingContext, const InitialConstraints& initialConstraints, Optional<TextAlignMode> horizontalAlignment, SkipAlignment skipAlignment) Double space before SkipAlignment > Source/WebCore/layout/inlineformatting/InlineLine.cpp:136 > + verticalAlignContent(); > + horizontalAlignContent(); alignContentVerticall() would read better, or just alignVertically(). But maybe there is some naming pattern here to match the property name?
alan
Comment 5 2019-09-28 17:57:45 PDT
Created attachment 379797 [details] Patch
alan
Comment 6 2019-09-28 17:58:15 PDT
(In reply to Antti Koivisto from comment #4) > Comment on attachment 379795 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=379795&action=review > > > Source/WebCore/layout/inlineformatting/InlineLine.cpp:60 > > +Line::Line(const InlineFormattingContext& inlineFormattingContext, const InitialConstraints& initialConstraints, Optional<TextAlignMode> horizontalAlignment, SkipAlignment skipAlignment) > > Double space before SkipAlignment > > > Source/WebCore/layout/inlineformatting/InlineLine.cpp:136 > > + verticalAlignContent(); > > + horizontalAlignContent(); > > alignContentVerticall() would read better, or just alignVertically(). But > maybe there is some naming pattern here to match the property name? Good point!
WebKit Commit Bot
Comment 7 2019-09-28 18:59:33 PDT
Comment on attachment 379797 [details] Patch Clearing flags on attachment: 379797 Committed r250487: <https://trac.webkit.org/changeset/250487>
WebKit Commit Bot
Comment 8 2019-09-28 18:59:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.