Bug 202346

Summary: [GTK] 2.26.1: webkitgtk is not LTO optimisation ready
Product: WebKit Reporter: Tomasz Kłoczko <kloczko.tomasz>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: bugs-noreply, clopez, john.frankish, mcatanzaro
Priority: P3 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
linking fail none

Tomasz Kłoczko
Reported 2019-09-28 09:46:15 PDT
When webkitgtk is build with LTO optimisation linking fails
Attachments
linking fail (103.91 KB, text/x-log)
2019-09-28 09:46 PDT, Tomasz Kłoczko 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Tomasz Kłoczko
Comment 1 2019-09-28 09:46:56 PDT
Created attachment 379787 [details] linking fail
Adrian Perez
Comment 2 2019-09-28 11:57:39 PDT
*** Bug 172356 has been marked as a duplicate of this bug. ***
Adrian Perez
Comment 3 2019-09-28 12:10:27 PDT
Tomasz, I have successfully built WebKitGTK (and WPE) many times with LTO enabled, with different combinations of compilers and linkers (GCC, Clang, lld, Gold) and it has always worked fine. LLVM's ThinLTO works as well. I see that “-Wl,--no-undefined” is being passed to the linker, and that is the most likely cause for the linker failure.
Tomasz Kłoczko
Comment 4 2019-09-28 12:21:04 PDT
Despite fact that you've been able to build WebKitGTK (I have no problems with libwpe, wpebackend-fdo and LTO) looks like 2.26.1 *is* broken. WebKitGTK compiles and links correctly when using LTO is disabled. I'm not fiddling in linker options to add -Wl,--no-undefined. I'm using now as linker options: $ rpm -E %build_ldflags -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -flto -flto-partition=none -fuse-linker-plugin If -Wl,--no-undefined is causing the issue it must be added by cmake. Any suggestions?
Tomasz Kłoczko
Comment 5 2019-10-04 09:58:44 PDT
Just tested 2.27.1 and looks like still it is not possible to build it as long as LTO optimisation is in use.
Tomasz Kłoczko
Comment 6 2020-04-24 10:52:51 PDT
Issue still is not resolved in 2.28.2 :(
Michael Catanzaro
Comment 7 2021-08-23 12:35:39 PDT
Should be fixed by 240354@main. Please try again and reopen if not. *** This bug has been marked as a duplicate of bug 228865 ***
Note You need to log in before you can comment on or make changes to this bug.