Bug 202307
| Summary: | [GStreamer] Incoherent usage of environment variables USE_PLAYBIN3 and WEBKIT_GST_USE_PLAYBIN3 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adrian Perez <aperez> |
| Component: | Platform | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Adrian Perez
Both environment variables are used, I believe there should be only
one of them:
% rg 'getenv\(".*PLAYBIN' Source
Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
230: if (g_getenv("USE_PLAYBIN3"))
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
2390: if ((isMediaSource() || url.protocolIs("mediastream") || g_getenv("WEBKIT_GST_USE_PLAYBIN3")))
%
(The “rg” tool is similar to “grep”.)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrian Perez
(In reply to Adrian Perez from comment #0)
> Both environment variables are used, I believe there should be only
> one of them:
>
> % rg 'getenv\(".*PLAYBIN' Source
> Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
> 230: if (g_getenv("USE_PLAYBIN3"))
This is a variable honored by *GStreamer*, here used to warn that
playback issues may arise from setting it, because makes GStreamer
use “playbin3” whenever client code tries to instantiate “playbin”.
> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
> 2390: if ((isMediaSource() || url.protocolIs("mediastream") ||
> g_getenv("WEBKIT_GST_USE_PLAYBIN3")))
> %
And here this one is used to explicitly choose the “playbin3” element
(instead of “playbin”).
I guess this is not really a bug in the end, closing (and sorry
about the noise.)