Bug 20227

Summary: Optimize [ "constant string" ] into an identifier access.
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED WONTFIX    
Severity: Normal CC: zwarich
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
the patch! (changes nodes.cpp)
none
Patch, -1.5% on sunspider :-( none

Gavin Barraclough
Reported 2008-07-30 08:25:27 PDT
Optimize bracket nodes where the subscript is a constant string to just emit an identifier access. Will help code like the test case in: https://bugs.webkit.org/show_bug.cgi?id=20209 (takes f2() from .61s to .46s on my MPB) Should have no impact on sunspider, this case does not occur. patch in 5... 4... 3...
Attachments
the patch! (changes nodes.cpp) (6.41 KB, patch)
2008-07-30 08:43 PDT, Gavin Barraclough 		no flags
DetailsFormatted DiffDiff
Patch, -1.5% on sunspider :-( (9.22 KB, patch)
2008-08-19 13:15 PDT, Gavin Barraclough 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2008-07-30 08:43:02 PDT
Created attachment 22553 [details] the patch! (changes nodes.cpp) oh, s/MPB/MBP/ in my last comment. :-)
Cameron Zwarich (cpst)
Comment 2 2008-08-01 16:09:18 PDT
Comment on attachment 22553 [details] the patch! (changes nodes.cpp) r=me I would like a layout test, though.
Gavin Barraclough
Comment 3 2008-08-19 13:15:55 PDT
Created attachment 22880 [details] Patch, -1.5% on sunspider :-(
Gavin Barraclough
Comment 4 2010-03-02 17:54:36 PST
Patch wildly out of date, and I don't know there to be a real world benefit here. Closing for now, if we want to look at this again we can start from scratch.
Note You need to log in before you can comment on or make changes to this bug.