Bug 202243

Summary: Update availability annotations to match the macOS 10.15 and iOS 13.0 GM SDKs
Product: WebKit Reporter: Keith Rollin <krollin>
Component: WebKit APIAssignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, beidson, bfulgham, cdumez, commit-queue, mitz, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from webkit-cq-03 for mac-highsierra none

Description Keith Rollin 2019-09-25 15:12:03 PDT 
Changed WK_MAC_TBA and WK_IOS_TBA to 10.15 and 13.0, respectively, in all declarations that appear in the GM SDKs.
Comment 1 Radar WebKit Bug Importer 2019-09-25 15:12:16 PDT 
<rdar://problem/55720747>
Comment 2 Keith Rollin 2019-09-25 15:12:50 PDT 
<rdar://problem/55633104>
Comment 3 Keith Rollin 2019-09-25 15:18:43 PDT 
Created attachment 379583 [details]
Patch
Comment 4 Keith Rollin 2019-10-10 12:18:49 PDT 
Bump.
Comment 5 Keith Rollin 2019-11-04 10:01:49 PST 
Bump.
Comment 6 Keith Rollin 2019-11-06 09:39:08 PST 
Comment on attachment 379583 [details]
Patch

Brent Fulgham r+'d in Radar.
Comment 7 Keith Rollin 2019-11-06 09:39:58 PST 
I cq+'s too early. I need to add Brent to the ChangeLog.
Comment 8 Brent Fulgham 2019-11-06 09:40:27 PST 
Comment on attachment 379583 [details]
Patch

Here! I'll r+ for real.
Comment 9 Keith Rollin 2019-11-06 09:41:44 PST 
Comment on attachment 379583 [details]
Patch

Yay!
Comment 10 Wenson Hsieh 2019-11-06 09:52:12 PST 
Comment on attachment 379583 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379583&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:129
> +@property (nonatomic, setter=_setShouldAllowDesignSystemUIFonts:) BOOL _shouldAllowDesignSystemUIFonts WK_API_AVAILABLE(macos(10.15), ios(13.0));

I don’t think this one is present in 10.15/13.0 SDKs, since it landed quite recently. (That said, perhaps we should simply delete this one, per https://bugs.webkit.org/show_bug.cgi?id=203549#c4)
Comment 11 WebKit Commit Bot 2019-11-06 10:11:15 PST 
Comment on attachment 379583 [details]
Patch

Rejecting attachment 379583 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 379583, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 5000 characters of output:
webkit.org/attachment.cgi?id=379583
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Brent Fulgham']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 43 diffs from patch file(s).
patching file Source/WebKit/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/Configurations/WebKit.xcconfig
Hunk #1 succeeded at 156 (offset -7 lines).
patching file Source/WebKit/Shared/API/Cocoa/WKMain.h
patching file Source/WebKit/UIProcess/API/Cocoa/NSAttributedString.h
patching file Source/WebKit/UIProcess/API/Cocoa/WKContextMenuElementInfo.h
patching file Source/WebKit/UIProcess/API/Cocoa/WKError.h
patching file Source/WebKit/UIProcess/API/Cocoa/WKErrorPrivate.h
patching file Source/WebKit/UIProcess/API/Cocoa/WKNavigation.h
patching file Source/WebKit/UIProcess/API/Cocoa/WKNavigationActionPrivate.h
patching file Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegate.h
patching file Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h
patching file Source/WebKit/UIProcess/API/Cocoa/WKNavigationResponsePrivate.h
patching file Source/WebKit/UIProcess/API/Cocoa/WKPreferences.h
patching file Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h
Hunk #3 succeeded at 153 with fuzz 2.
Hunk #4 succeeded at 205 with fuzz 2 (offset 2 lines).
patching file Source/WebKit/UIProcess/API/Cocoa/WKPreviewActionItem.h
patching file Source/WebKit/UIProcess/API/Cocoa/WKPreviewActionItemIdentifiers.h
patching file Source/WebKit/UIProcess/API/Cocoa/WKPreviewElementInfo.h
patching file Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h
Hunk #1 FAILED at 89.
Hunk #2 FAILED at 111.
Hunk #3 succeeded at 125 with fuzz 2 (offset -1 lines).
2 out of 3 hunks FAILED -- saving rejects to file Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h.rej
patching file Source/WebKit/UIProcess/API/Cocoa/WKSnapshotConfiguration.h
patching file Source/WebKit/UIProcess/API/Cocoa/WKUIDelegate.h
patching file Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h
Hunk #1 succeeded at 113 (offset 1 line).
Hunk #2 succeeded at 146 (offset 3 lines).
Hunk #3 succeeded at 201 (offset 3 lines).
patching file Source/WebKit/UIProcess/API/Cocoa/WKURLSchemeTaskPrivate.h
patching file Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.h
patching file Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h
patching file Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
Hunk #2 succeeded at 139 (offset 3 lines).
Hunk #3 succeeded at 179 (offset 3 lines).
Hunk #4 succeeded at 234 (offset 3 lines).
Hunk #5 succeeded at 275 (offset 3 lines).
Hunk #6 succeeded at 288 (offset 3 lines).
Hunk #7 succeeded at 363 (offset 3 lines).
Hunk #8 succeeded at 376 (offset 3 lines).
Hunk #9 succeeded at 417 (offset 3 lines).
Hunk #10 succeeded at 432 (offset 3 lines).
Hunk #11 succeeded at 470 (offset 3 lines).
Hunk #12 succeeded at 501 (offset 3 lines).
Hunk #13 succeeded at 582 with fuzz 2 (offset 8 lines).
patching file Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.h
patching file Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataRecordPrivate.h
patching file Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h
Hunk #2 FAILED at 67.
1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h.rej
patching file Source/WebKit/UIProcess/API/Cocoa/_WKActivatedElementInfo.h
patching file Source/WebKit/UIProcess/API/Cocoa/_WKAutomationSessionDelegate.h
patching file Source/WebKit/UIProcess/API/Cocoa/_WKContentRuleListAction.h
patching file Source/WebKit/UIProcess/API/Cocoa/_WKCustomHeaderFields.h
patching file Source/WebKit/UIProcess/API/Cocoa/_WKDiagnosticLoggingDelegate.h
patching file Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.h
patching file Source/WebKit/UIProcess/API/Cocoa/_WKInspectorWindow.h
patching file Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h
Hunk #3 FAILED at 70.
1 out of 3 hunks FAILED -- saving rejects to file Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h.rej
patching file Source/WebKit/UIProcess/API/Cocoa/_WKTextInputContext.h
patching file Source/WebKit/UIProcess/API/Cocoa/_WKUserContentExtensionStorePrivate.h
patching file Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h
Hunk #1 FAILED at 33.
Hunk #2 succeeded at 71 with fuzz 1 (offset 5 lines).
1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.h.rej
patching file Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreDelegate.h
patching file Source/WebKit/UIProcess/API/Cocoa/_WKWebsitePolicies.h
patching file Source/WebKit/UIProcess/_WKTouchEventGenerator.h
patching file Source/WebKit/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Brent Fulgham']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/13219455
Comment 12 Keith Rollin 2019-11-06 11:01:38 PST 
I think I need to rebase. I'll also double-check Wenson's comment.
Comment 13 Keith Rollin 2019-11-06 14:50:16 PST 
(In reply to Wenson Hsieh from comment #10)
> Comment on attachment 379583 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=379583&action=review
> 
> > Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:129
> > +@property (nonatomic, setter=_setShouldAllowDesignSystemUIFonts:) BOOL _shouldAllowDesignSystemUIFonts WK_API_AVAILABLE(macos(10.15), ios(13.0));
> 
> I don’t think this one is present in 10.15/13.0 SDKs, since it landed quite
> recently. (That said, perhaps we should simply delete this one, per
> https://bugs.webkit.org/show_bug.cgi?id=203549#c4)

I checked in Xcode11M382v_m18A391011_m19A583_i17A878_t17J586_w17R605_b17P572_FastSim_Boost_47GB, and see it in the macOS 10.15 and iOS 13 SDKs.
Comment 14 Keith Rollin 2019-11-06 15:24:01 PST 
Created attachment 382967 [details]
Patch
Comment 15 WebKit Commit Bot 2019-11-06 18:27:49 PST 
Comment on attachment 382967 [details]
Patch

Rejecting attachment 382967 [details] from commit-queue.

New failing tests:
webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html
Full output: https://webkit-queues.webkit.org/results/13220896
Comment 16 WebKit Commit Bot 2019-11-06 18:27:51 PST 
Created attachment 383001 [details]
Archive of layout-test-results from webkit-cq-03 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-03  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 17 WebKit Commit Bot 2019-11-06 22:37:40 PST 
Comment on attachment 382967 [details]
Patch

Clearing flags on attachment: 382967

Committed r252174: <https://trac.webkit.org/changeset/252174>
Comment 18 WebKit Commit Bot 2019-11-06 22:37:42 PST 
All reviewed patches have been landed.  Closing bug.
Comment 19 Alex Christensen 2019-11-07 06:33:04 PST 
Comment on attachment 382967 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=382967&action=review

> Source/WebKit/UIProcess/API/Cocoa/NSAttributedString.h:46
> -    NS_SWIFT_NAME(readAccessURL) WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
> +    NS_SWIFT_NAME(readAccessURL) WK_API_AVAILABLE(macos(10.15), ios(13.0));

This seems to have broken the Catalina build.
Comment 20 Alex Christensen 2019-11-07 06:50:04 PST 
It only broke the incremental build.  Clean build fixes it.