Bug 202203

Summary: Position::upstream/downstream should not need to call ensureLineBoxes
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, glenn, kangil.han, kondapallykalyan, mmaxfield, pdr, webkit-bug-importer, wenson_hsieh, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
ews-watchlist: commit-queue-
Archive of layout-test-results from ews214 for win-future
none
patch
none
wip
ews-watchlist: commit-queue-
Archive of layout-test-results from ews215 for win-future
none
wip
none
wip
none
patch
none
patch
none
patch none

Description Antti Koivisto 2019-09-25 07:36:43 PDT
The code doesn't require lineboxes anymore.
Comment 1 Antti Koivisto 2019-09-25 07:37:29 PDT
Created attachment 379548 [details]
patch
Comment 2 EWS Watchlist 2019-09-25 09:32:27 PDT
Comment on attachment 379548 [details]
patch

Attachment 379548 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13067068

New failing tests:
fast/forms/textarea-paste-newline.html
fast/text/whitespace/pre-wrap-overflow-selection.html
editing/inserting/4960120-1.html
fast/text/pre-wrap-trailing-tab.html
Comment 3 EWS Watchlist 2019-09-25 09:32:37 PDT
Created attachment 379555 [details]
Archive of layout-test-results from ews214 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews214  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 4 Antti Koivisto 2019-10-10 03:03:40 PDT
Created attachment 380622 [details]
patch
Comment 5 Antti Koivisto 2019-10-10 08:32:20 PDT
Created attachment 380644 [details]
wip
Comment 6 EWS Watchlist 2019-10-10 14:32:00 PDT
Comment on attachment 380644 [details]
wip

Attachment 380644 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13115609

New failing tests:
fast/text/simple-line-layout-multiple-trailingwhitespace-crash.html
fast/forms/basic-textareas-quirks-simple-lines.html
fast/loader/text-document-wrapping.html
fast/forms/textarea-scroll-height.html
fast/parser/open-comment-in-textarea.html
fast/css/font-face-zero-hash-key.html
platform/win/editing/selection/shift-page-up-down.html
fast/forms/targeted-frame-submission.html
fast/selectors/text-field-selection-text-shadow.html
Comment 7 EWS Watchlist 2019-10-10 14:32:03 PDT
Created attachment 380684 [details]
Archive of layout-test-results from ews215 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews215  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 8 Antti Koivisto 2019-10-11 02:59:12 PDT
Created attachment 380737 [details]
wip
Comment 9 Antti Koivisto 2019-10-11 07:05:24 PDT
Created attachment 380750 [details]
wip
Comment 10 Antti Koivisto 2019-10-11 08:17:03 PDT
Created attachment 380756 [details]
patch
Comment 11 Antti Koivisto 2019-10-11 09:14:19 PDT
Created attachment 380759 [details]
patch
Comment 12 Antti Koivisto 2019-10-11 09:35:13 PDT
Created attachment 380760 [details]
patch
Comment 13 WebKit Commit Bot 2019-10-11 12:03:45 PDT
Comment on attachment 380760 [details]
patch

Clearing flags on attachment: 380760

Committed r251015: <https://trac.webkit.org/changeset/251015>
Comment 14 WebKit Commit Bot 2019-10-11 12:03:47 PDT
All reviewed patches have been landed.  Closing bug.
Comment 15 Radar WebKit Bug Importer 2019-10-11 12:04:24 PDT
<rdar://problem/56199072>