Bug 202180 – [results.webkit.org] Timeline support Image inner label

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Zhifei Fang]

[results.webkit.org] Timeline support Image inner label

[Zhifei Fang]

Created attachment 379519 [details]
Patch

[Jonathan Bedard]

This is going to conflict with https://bugs.webkit.org/show_bug.cgi?id=202106, that's my only concern.

Two other things I also wonder about:

For the HTML, can we not just have the SVG in place of the character? Obviously won't work on the canvas

Is it possible to make this symbol with zero-width unicode characters? I didn't think of that earlier, but it should be possible, and wouldn't require us to do the whole is-it-an-image check.

[Zhifei Fang]

(In reply to Jonathan Bedard from comment #2)
> This is going to conflict with
> https://bugs.webkit.org/show_bug.cgi?id=202106, that's my only concern.
> 
> Two other things I also wonder about:
> 
> For the HTML, can we not just have the SVG in place of the character?
> Obviously won't work on the canvas

Adding toString() for Image, Image.prototype.toString = function() {return this.outerHTML}

For canvas, it is better to directly provide an Image Object, I don't want to create an image object for each dot, this can drain memory quickly. So it will need another system to cache image by its digest.

> 
> Is it possible to make this symbol with zero-width unicode characters? I
> didn't think of that earlier, but it should be possible, and wouldn't
> require us to do the whole is-it-an-image check.

adding toString of Image will resolve this in most case.

[Zhifei Fang]

Created attachment 379665 [details]
Patch

[Jonathan Bedard]

You haven't included clock.svg in the patch.

[Zhifei Fang]

Created attachment 379668 [details]
Patch

[Zhifei Fang]

Created attachment 379670 [details]
Patch

[Jonathan Bedard]

Comment on attachment 379670 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379670&action=review

> Tools/resultsdbpy/resultsdbpy/view/static/library/icons/clock.svg:6
> +        <dc:date>2019-09-24 23:32:28 +0000</dc:date>

Do we need the metadata?

[Zhifei Fang]

Created attachment 379673 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 379673 [details]
Patch

Clearing flags on attachment: 379673

Committed r250399: <https://trac.webkit.org/changeset/250399>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/55759680>