Bug 202154

Summary: Address static analysis warning in ParkingLot.cpp: Access to field 'size' results in a dereference of a null pointer
Product: WebKit Reporter: Keith Rollin <krollin>
Component: Web Template FrameworkAssignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, fpizlo, mark.lam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Keith Rollin
Reported 2019-09-24 12:15:57 PDT
Static analysis reports the following: .../OpenSource/Source/WTF/wtf/ParkingLot.cpp:376:30: warning: Access to field 'size' results in a dereference of a null pointer (loaded from variable 'oldHashtable') RELEASE_ASSERT(newSize > oldHashtable->size); ^~~~~~~~~~~~~~~~~~ This warning arises because earlier code checks to see if oldHashtable is NULL, leading the static analyzer to think that it *could* be NULL. However, earlier code actually ensures that oldhashtable will not be NULL. Address this by removing the NULL check, and back it up with an ASSERT to ensure that it's not NULL.
Attachments
Patch (2.41 KB, patch)
2019-09-24 12:18 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-09-24 12:16:14 PDT
<rdar://problem/55672103>
Keith Rollin
Comment 2 2019-09-24 12:18:09 PDT
Created attachment 379465 [details] Patch
Brent Fulgham
Comment 3 2019-09-29 15:51:25 PDT
Comment on attachment 379465 [details] Patch This seems like a reasonable change.
WebKit Commit Bot
Comment 4 2019-09-29 19:21:55 PDT
Comment on attachment 379465 [details] Patch Clearing flags on attachment: 379465 Committed r250497: <https://trac.webkit.org/changeset/250497>
WebKit Commit Bot
Comment 5 2019-09-29 19:21:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.