Bug 202149

Summary: testapi: slow devices need more time before watchdog fires
Product: WebKit Reporter: Guillaume Emont <guijemont>
Component: JavaScriptCoreAssignee: Guillaume Emont <guijemont>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, ticaiolima, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Guillaume Emont
Reported 2019-09-24 10:05:46 PDT
In testExecutionTimeLimit(), the time that we leave for the watchdog to fire is often not enough on (slower) arm and mips devices, creating a testapi failure.
Attachments
Patch (2.44 KB, patch)
2019-09-24 10:10 PDT, Guillaume Emont 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Guillaume Emont
Comment 1 2019-09-24 10:10:53 PDT
Created attachment 379459 [details] Patch Patch fixing this, and also skipping FTL-specific cases when FTL is disabled.
Caio Lima
Comment 2 2019-09-24 10:35:05 PDT
Comment on attachment 379459 [details] Patch Informal r+ here. LGTM if bots are green.
Guillaume Emont
Comment 3 2019-09-24 11:02:23 PDT
(In reply to Caio Lima from comment #2) > Comment on attachment 379459 [details] > Patch > > Informal r+ here. LGTM if bots are green. Note that arm and mips bots currently don't run testapi & friends. I will do more checks, but I think this was the last hurdle to enabling them (patch enabling them already exists in Bug 195404).
Guillaume Emont
Comment 4 2019-09-25 02:27:06 PDT
Comment on attachment 379459 [details] Patch Landing, as the ios-wk2 bot failures are clearly unrelated, as this change cannot affect layout tests.
WebKit Commit Bot
Comment 5 2019-09-25 03:11:12 PDT
Comment on attachment 379459 [details] Patch Clearing flags on attachment: 379459 Committed r250340: <https://trac.webkit.org/changeset/250340>
WebKit Commit Bot
Comment 6 2019-09-25 03:11:13 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-09-25 03:12:15 PDT
<rdar://problem/55698076>
Note You need to log in before you can comment on or make changes to this bug.