Summary: | Make IsNSURLSessionWebSocketEnabled an experimental flag | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
Component: | Page Loading | Assignee: | youenn fablet <youennf> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | beidson, commit-queue, ggaren, tsavell, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 202210 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
youenn fablet
2019-09-23 23:41:00 PDT
Created attachment 379435 [details]
Patch
Comment on attachment 379435 [details]
Patch
r=me
The commit-queue encountered the following flaky tests while processing attachment 379435 [details]: inspector/canvas/updateShader.html bug 202186 (authors: drousso@apple.com and tsavell@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 379435 [details] Patch Clearing flags on attachment: 379435 Committed r250336: <https://trac.webkit.org/changeset/250336> All reviewed patches have been landed. Closing bug. It looks like the change in this commit: https://trac.webkit.org/changeset/250336/webkit broke ~110 tests on ios-wk2. It does look like iOS EWS caught this issue as well. Results: https://build.webkit.org/builders/Apple%20iOS%2013%20Simulator%20Release%20WK2%20%28Tests%29/builds/145 I'll roll it out and will reland it tomorrow. Re-opened since this is blocked by bug 202210 Created attachment 379632 [details]
Patch
Comment on attachment 379632 [details] Patch Clearing flags on attachment: 379632 Committed r250417: <https://trac.webkit.org/changeset/250417> All reviewed patches have been landed. Closing bug. |