Bug 202135

Summary: Make IsNSURLSessionWebSocketEnabled an experimental flag
Product: WebKit Reporter: youenn fablet <youennf>
Component: Page LoadingAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, commit-queue, ggaren, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 202210    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description youenn fablet 2019-09-23 23:41:00 PDT
Make IsNSURLSessionWebSocketEnabled an experimental flag
Comment 1 youenn fablet 2019-09-23 23:41:36 PDT
Created attachment 379435 [details]
Patch
Comment 2 Geoffrey Garen 2019-09-24 10:20:16 PDT
Comment on attachment 379435 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2019-09-25 00:26:18 PDT
The commit-queue encountered the following flaky tests while processing attachment 379435 [details]:

inspector/canvas/updateShader.html bug 202186 (authors: drousso@apple.com and tsavell@apple.com)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2019-09-25 00:27:06 PDT
Comment on attachment 379435 [details]
Patch

Clearing flags on attachment: 379435

Committed r250336: <https://trac.webkit.org/changeset/250336>
Comment 5 WebKit Commit Bot 2019-09-25 00:27:08 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-09-25 00:28:15 PDT
<rdar://problem/55694721>
Comment 7 Truitt Savell 2019-09-25 09:54:40 PDT
It looks like the change in this commit: https://trac.webkit.org/changeset/250336/webkit

broke ~110 tests on ios-wk2. It does look like iOS EWS caught this issue as well. 

Results:
https://build.webkit.org/builders/Apple%20iOS%2013%20Simulator%20Release%20WK2%20%28Tests%29/builds/145
Comment 8 youenn fablet 2019-09-25 10:01:17 PDT
I'll roll it out and will reland it tomorrow.
Comment 9 WebKit Commit Bot 2019-09-25 10:02:28 PDT
Re-opened since this is blocked by bug 202210
Comment 10 youenn fablet 2019-09-26 04:33:51 PDT
Created attachment 379632 [details]
Patch
Comment 11 WebKit Commit Bot 2019-09-27 02:04:42 PDT
Comment on attachment 379632 [details]
Patch

Clearing flags on attachment: 379632

Committed r250417: <https://trac.webkit.org/changeset/250417>
Comment 12 WebKit Commit Bot 2019-09-27 02:04:44 PDT
All reviewed patches have been landed.  Closing bug.