Bug 202075

Summary: clip-path: <geometry-box> mapping incorrect
Product: WebKit Reporter: Dirk Schulze <krit>
Component: CSSAssignee: Dirk Schulze <krit>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 126207    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description Dirk Schulze 2019-09-21 02:19:59 PDT 
The mapping of the <geometry-box> for clip-path is implemented differently than in the spec: https://drafts.fxtf.org/css-masking-1/#the-clip-path

Spec changed after requests of the CSS WG to match the mapping in Fill And Stroke and CSS Transform spec.

https://github.com/w3c/fxtf-drafts/commit/2c7d4824101be55bcc0b4604fb3ac86b86176227
Comment 1 Dirk Schulze 2019-09-21 09:37:39 PDT 
Created attachment 379318 [details]
Patch
Comment 2 Dirk Schulze 2019-09-21 10:04:34 PDT 
Hm. Seems like we don’t have tests in place for this change. All bots are green. Will upload a test.
Comment 3 Darin Adler 2019-09-21 11:33:28 PDT 
Comment on attachment 379318 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379318&action=review

> Source/WebCore/ChangeLog:14
> +        Covered by existing tests.

If this is covered by existing tests, then why wasn’t there a failing test that changes to succeeding when we fix the bug?
Comment 4 Darin Adler 2019-09-21 11:33:45 PDT 
Oh, I see your comment now, sorry!
Comment 5 Dirk Schulze 2019-09-23 09:35:42 PDT 
Created attachment 379375 [details]
Patch
Comment 6 Nikolas Zimmermann 2019-09-24 09:40:25 PDT 
Comment on attachment 379375 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379375&action=review

LGTM.

> Source/WebCore/rendering/shapes/BoxShape.cpp:86
> +    // stroke, view-box compute to border-box for HTML elements.

s/stroke/stroke-box/?
Comment 7 Simon Fraser (smfr) 2019-10-02 14:55:12 PDT 
Comment on attachment 379375 [details]
Patch

This looks like it conflicts with your other patch.
Comment 8 Dirk Schulze 2019-10-05 09:23:36 PDT 
Created attachment 380286 [details]
Patch for landing
Comment 9 Dirk Schulze 2019-10-05 09:25:49 PDT 
Similar to https://bugs.webkit.org/show_bug.cgi?id=201892 Not sure if I don't have committer rights anymore (last path last year) or if there is a mistake in the contributions.json file. Simon, could you cq+ please?
Comment 10 WebKit Commit Bot 2019-10-07 11:35:07 PDT 
Comment on attachment 380286 [details]
Patch for landing

Clearing flags on attachment: 380286

Committed r250778: <https://trac.webkit.org/changeset/250778>
Comment 11 WebKit Commit Bot 2019-10-07 11:35:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2019-10-07 11:36:17 PDT 
<rdar://problem/56044543>