Summary: | clip-path: <geometry-box> mapping incorrect | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dirk Schulze <krit> | ||||||||
Component: | CSS | Assignee: | Dirk Schulze <krit> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, darin, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zimmermann | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 126207 | ||||||||||
Attachments: |
|
Description
Dirk Schulze
2019-09-21 02:19:59 PDT
Created attachment 379318 [details]
Patch
Hm. Seems like we don’t have tests in place for this change. All bots are green. Will upload a test. Comment on attachment 379318 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379318&action=review > Source/WebCore/ChangeLog:14 > + Covered by existing tests. If this is covered by existing tests, then why wasn’t there a failing test that changes to succeeding when we fix the bug? Oh, I see your comment now, sorry! Created attachment 379375 [details]
Patch
Comment on attachment 379375 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379375&action=review LGTM. > Source/WebCore/rendering/shapes/BoxShape.cpp:86 > + // stroke, view-box compute to border-box for HTML elements. s/stroke/stroke-box/? Comment on attachment 379375 [details]
Patch
This looks like it conflicts with your other patch.
Created attachment 380286 [details]
Patch for landing
Similar to https://bugs.webkit.org/show_bug.cgi?id=201892 Not sure if I don't have committer rights anymore (last path last year) or if there is a mistake in the contributions.json file. Simon, could you cq+ please? Comment on attachment 380286 [details] Patch for landing Clearing flags on attachment: 380286 Committed r250778: <https://trac.webkit.org/changeset/250778> All reviewed patches have been landed. Closing bug. |