Bug 202066

Summary: eliding a move in Air O0 needs to mark the dest's old reg as available
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Keith Miller
Reported 2019-09-20 17:19:13 PDT
eliding a move in Air O0 needs to mark the dest's old reg as available
Attachments
Patch (4.35 KB, patch)
2019-09-20 17:21 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (4.35 KB, patch)
2019-09-20 17:22 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.31 KB, patch)
2019-09-20 17:53 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.30 KB, patch)
2019-09-20 17:54 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2019-09-20 17:21:01 PDT
Created attachment 379290 [details] Patch
Keith Miller
Comment 2 2019-09-20 17:22:07 PDT
Created attachment 379291 [details] Patch
Saam Barati
Comment 3 2019-09-20 17:47:24 PDT
Comment on attachment 379291 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379291&action=review > Source/JavaScriptCore/b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp:128 > + if (reg || (reg = m_map[tmp].reg)) { can this assignment happen not in the if?
Keith Miller
Comment 4 2019-09-20 17:53:28 PDT
Created attachment 379295 [details] Patch for landing
Keith Miller
Comment 5 2019-09-20 17:54:21 PDT
Created attachment 379296 [details] Patch for landing
WebKit Commit Bot
Comment 6 2019-09-20 19:11:44 PDT
Comment on attachment 379296 [details] Patch for landing Clearing flags on attachment: 379296 Committed r250176: <https://trac.webkit.org/changeset/250176>
WebKit Commit Bot
Comment 7 2019-09-20 19:11:45 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-09-20 19:18:23 PDT
<rdar://problem/55580417>
Note You need to log in before you can comment on or make changes to this bug.