Bug 202007
| Summary: | When reifying a custom accessor, we should consider using CustomGetterSetter instead of GetterSetter | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> |
| Component: | JavaScriptCore | Assignee: | Saam Barati <saam> |
| Status: | NEW | ||
| Severity: | Normal | CC: | benjamin, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, tzagallo, ysuzuki |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Saam Barati
I'm not sure why we do it the way we currently do, but it seems bad for perf. Since our ICs already know how to call into custom accessors directly, by caching it as a JS getter/setter with a JSFunction which wraps native code, we're just being circuitous. There's probably a reason why it's currently done this way, perhaps to answer getOwnPropertyDescriptor queries, but we could do better.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |