Bug 201935
| Summary: | [ews] Rebuilding for retries should be done on builders instead of testers especially for macOS Sequoia | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> |
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aakash_jain, ap, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=306537 https://bugs.webkit.org/show_bug.cgi?id=306627 |
||
Aakash Jain
When a test requires building a clean tree, we currently do that on testers.
We should do that on builders, so that we could use slower hardware for testers when necessary. Notably, Mac API tests are single process.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Aakash Jain
<rdar://problem/49789674>
Aakash Jain
Pull request: https://github.com/WebKit/WebKit/pull/55031
EWS
Committed 306099@main (4102038712b1): <https://commits.webkit.org/306099@main>
Reviewed commits have been landed. Closing PR #55031 and removing active labels.
Aakash Jain
The feature was deployed/enabled yesterday and seems to be working as expected. e.g.:
- Builder queue building without change: https://ews-build.webkit.org/#/builders/168/builds/3062#bb-step-24
- Tester queue downloading the build without change (instead of building locally): https://ews-build.webkit.org/#/builders/169/builds/2931#bb-step-38
- Tester queue even triggering parent build again (e.g.: in case it can't confirm failure): https://ews-build.webkit.org/#/builders/169/builds/2920#bb-step-49
Also, incremental builds seems to be actually fast :)
For e.g., in these builds, compile-webkit took ~40-50 minutes, but compile-webkit-without-change step took only ~1-2 minutes.
https://ews-build.webkit.org/#/builders/168/builds/3095, https://ews-build.webkit.org/#/builders/168/builds/3097, https://ews-build.webkit.org/#/builders/168/builds/3101, https://ews-build.webkit.org/#/builders/168/builds/3107