Bug 201895

Summary: [cairo] Incorrect targetRect in BackingStoreBackendCairoImpl::scroll
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: PlatformAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, magomez, mrobinson, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=59655
https://bugs.webkit.org/show_bug.cgi?id=83309
Attachments:
Description Flags
Patch none

Fujii Hironori
Reported 2019-09-17 20:44:39 PDT
[cairo] Incorrect targetRect in BackingStoreBackendCairoImpl::scroll In BackingStoreBackendCairoImpl::scroll, targetRect is calculated wrongly by shifting maxX and manxY. > IntRect targetRect = scrollRect; > targetRect.move(scrollOffset); > targetRect.shiftMaxXEdgeTo(targetRect.maxX() - scrollOffset.width()); > targetRect.shiftMaxYEdgeTo(targetRect.maxY() - scrollOffset.height()); This code came from Bug 59655. On the other hand, Bug 83309 fixed BackingStoreBackendCairoX11::scroll. > IntRect targetRect = scrollRect; > targetRect.move(scrollOffset); > targetRect.intersect(scrollRect);
Attachments
Patch (1.90 KB, patch)
2019-09-17 20:54 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2019-09-17 20:54:23 PDT
Created attachment 379017 [details] Patch
Fujii Hironori
Comment 2 2019-09-18 00:57:17 PDT
Comment on attachment 379017 [details] Patch Clearing flags on attachment: 379017 Committed r250027: <https://trac.webkit.org/changeset/250027>
Fujii Hironori
Comment 3 2019-09-18 00:57:21 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-09-18 00:58:22 PDT
<rdar://problem/55469927>
Note You need to log in before you can comment on or make changes to this bug.