Bug 201845

Summary: [WebAuthn] Name instance variables consistently in WKMockNFTag
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebKit2Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, jiewen_tan, krollin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=201813
https://bugs.webkit.org/show_bug.cgi?id=201839
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2019-09-16 15:05:50 PDT
Name instance variables consistently in WKMockNFTag. Bug 201813 and Bug 201839 fixed leaks by releasing instance variables in -dealloc, but the result is that only some synthesized instance variables have leading underscores in their names. This bug tracks making all of the instance variables use the same naming convention.
Attachments
Patch v1 (1.69 KB, patch)
2019-09-16 15:08 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-09-16 15:06:07 PDT
<rdar://problem/55416240>
David Kilzer (:ddkilzer)
Comment 2 2019-09-16 15:08:00 PDT
Created attachment 378899 [details] Patch v1
Jiewen Tan
Comment 3 2019-09-16 15:44:12 PDT
Comment on attachment 378899 [details] Patch v1 LGTM. r=me.
WebKit Commit Bot
Comment 4 2019-09-16 18:26:05 PDT
Comment on attachment 378899 [details] Patch v1 Clearing flags on attachment: 378899 Committed r249934: <https://trac.webkit.org/changeset/249934>
WebKit Commit Bot
Comment 5 2019-09-16 18:26:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.