Bug 201845

Summary: [WebAuthn] Name instance variables consistently in WKMockNFTag
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebKit2Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, jiewen_tan, krollin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=201813
https://bugs.webkit.org/show_bug.cgi?id=201839
Attachments:
Description Flags
Patch v1 none

Description David Kilzer (:ddkilzer) 2019-09-16 15:05:50 PDT 
Name instance variables consistently in WKMockNFTag.

Bug 201813 and Bug 201839 fixed leaks by releasing instance variables in -dealloc, but the result is that only some synthesized instance variables have leading underscores in their names.

This bug tracks making all of the instance variables use the same naming convention.
Comment 1 Radar WebKit Bug Importer 2019-09-16 15:06:07 PDT 
<rdar://problem/55416240>
Comment 2 David Kilzer (:ddkilzer) 2019-09-16 15:08:00 PDT 
Created attachment 378899 [details]
Patch v1
Comment 3 Jiewen Tan 2019-09-16 15:44:12 PDT 
Comment on attachment 378899 [details]
Patch v1

LGTM. r=me.
Comment 4 WebKit Commit Bot 2019-09-16 18:26:05 PDT 
Comment on attachment 378899 [details]
Patch v1

Clearing flags on attachment: 378899

Committed r249934: <https://trac.webkit.org/changeset/249934>
Comment 5 WebKit Commit Bot 2019-09-16 18:26:07 PDT 
All reviewed patches have been landed.  Closing bug.