Bug 201844 – [WebAuthn] LocalAuthenticator tests are failing on internal bots

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Jiewen Tan]

LocalAuthenticator tests are failing on internal bots.

[Jiewen Tan]

<rdar://problem/54278693>

[Jiewen Tan]

Created attachment 378901 [details]
Patch

[Jiewen Tan]

Created attachment 378915 [details]
Patch

[Brent Fulgham]

Comment on attachment 378915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378915&action=review

r = me

> Tools/ChangeLog:16
> +        be able to access it, and therefore eliminate any race condition. To assis it, a few new

To support this, a few .. ?

[Jiewen Tan]

Comment on attachment 378915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=378915&action=review

Thanks Brent for r+ this change.

>> Tools/ChangeLog:16
>> +        be able to access it, and therefore eliminate any race condition. To assis it, a few new
> 
> To support this, a few .. ?

Fixed.

[Jiewen Tan]

Created attachment 379289 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 379289 [details]
Patch for landing

Rejecting attachment 379289 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 379289, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=379289&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=201844&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 379289 from bug 201844.
Fetching: https://bugs.webkit.org/attachment.cgi?id=379289
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 27 diffs from patch file(s).
patching file Source/WebKit/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/UIProcess/API/C/WKWebsiteDataStoreRef.cpp
patching file Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm
Hunk #1 succeeded at 401 (offset 4 lines).
patching file Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.h
patching file Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm
patching file Source/WebKit/UIProcess/WebAuthentication/Mock/MockLocalConnection.h
patching file Source/WebKit/UIProcess/WebAuthentication/Mock/MockLocalConnection.mm
patching file Source/WebKit/UIProcess/WebAuthentication/Mock/MockWebAuthenticationConfiguration.h
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
Hunk #1 succeeded at 391 (offset -4 lines).
patching file Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
Hunk #1 succeeded at 2579 (offset -6 lines).
Hunk #2 succeeded at 2589 (offset -6 lines).
Hunk #3 succeeded at 2841 (offset -6 lines).
patching file Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
Hunk #1 succeeded at 488 (offset -1 lines).
patching file Tools/WebKitTestRunner/TestController.cpp
Hunk #1 succeeded at 3552 (offset 1 line).
patching file Tools/WebKitTestRunner/TestController.h
patching file Tools/WebKitTestRunner/TestInvocation.cpp
patching file Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/http/wpt/credential-management/credentialscontainer-store-basics.https.html
patching file LayoutTests/http/wpt/webauthn/idl.https.html
patching file LayoutTests/http/wpt/webauthn/public-key-credential-create-failure-local-silent.https.html
patching file LayoutTests/http/wpt/webauthn/public-key-credential-create-failure-local.https.html
patching file LayoutTests/http/wpt/webauthn/public-key-credential-create-success-local.https.html
Hunk #1 FAILED at 5.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/http/wpt/webauthn/public-key-credential-create-success-local.https.html.rej
patching file LayoutTests/http/wpt/webauthn/public-key-credential-get-failure-local-silent.https.html
patching file LayoutTests/http/wpt/webauthn/public-key-credential-get-failure-local.https.html
patching file LayoutTests/http/wpt/webauthn/public-key-credential-get-success-local.https.html
Hunk #1 FAILED at 4.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/http/wpt/webauthn/public-key-credential-get-success-local.https.html.rej
patching file LayoutTests/http/wpt/webauthn/resources/util.js
patching file LayoutTests/platform/mac-wk2/TestExpectations
Hunk #1 succeeded at 890 (offset -13 lines).

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/13055379

[Jiewen Tan]

Committed r250249: <https://trac.webkit.org/changeset/250249>