Bug 20182

Summary:

use --outputDir option of make_names.pl instead of --output

Product:

WebKit

Reporter:

Jan Alonzo <jmalonzo>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
patch to fix the build scripts	eric: review+
updated: remove output for DerivedSources.make	eric: review+

Jan Alonzo

Reported 2008-07-26 16:40:54 PDT

make_names.pl recognizes 'outputDir' as an option and not 'output'. We should be using --outputDir in our build scripts.

Attachments
patch to fix the build scripts (11.71 KB, patch) 2008-07-26 16:41 PDT, Jan Alonzo	eric: review+	Details Formatted Diff Diff
updated: remove output for DerivedSources.make (12.44 KB, patch) 2008-07-26 23:12 PDT, Jan Alonzo	eric: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jan Alonzo

Comment 1 2008-07-26 16:41:56 PDT

Created attachment 22495 [details] patch to fix the build scripts Fixes DerivedSources.make, GNUmakefile.am and WebCore.pro.

Mark Rowe (bdash)

Comment 2 2008-07-26 21:45:03 PDT

Is the argument needed? If the scripts have been using the incorrect name for all this time and there have been no negative side effect, perhaps there is no need for it to be passed at all?

Eric Seidel (no email)

Comment 3 2008-07-26 22:42:40 PDT

Comment on attachment 22495 [details] patch to fix the build scripts Looks good.

Jan Alonzo

Comment 4 2008-07-26 23:12:09 PDT

Created attachment 22498 [details] updated: remove output for DerivedSources.make Patch updated to remove --output from DerivedSources.make since it's not needed there. Renaming --output to --outputDir for Qt and Gtk build scripts.

Eric Seidel (no email)

Comment 5 2008-07-27 02:25:24 PDT

Comment on attachment 22498 [details] updated: remove output for DerivedSources.make Looks fine.

Jan Alonzo

Comment 6 2008-07-27 03:44:14 PDT

Thanks. Landed in r35402

Note You need to log in before you can comment on or make changes to this bug.