|Summary:||use --outputDir option of make_names.pl instead of --output|
|Product:||WebKit||Reporter:||Jan Alonzo <jmalonzo>|
|Component:||New Bugs||Assignee:||Nobody <webkit-unassigned>|
|Version:||528+ (Nightly build)|
Description Jan Alonzo 2008-07-26 16:40:54 PDT
make_names.pl recognizes 'outputDir' as an option and not 'output'. We should be using --outputDir in our build scripts.
Comment 1 Jan Alonzo 2008-07-26 16:41:56 PDT
Created attachment 22495 [details] patch to fix the build scripts Fixes DerivedSources.make, GNUmakefile.am and WebCore.pro.
Comment 2 Mark Rowe (bdash) 2008-07-26 21:45:03 PDT
Is the argument needed? If the scripts have been using the incorrect name for all this time and there have been no negative side effect, perhaps there is no need for it to be passed at all?
Comment 3 Eric Seidel (no email) 2008-07-26 22:42:40 PDT
Comment on attachment 22495 [details] patch to fix the build scripts Looks good.
Comment 4 Jan Alonzo 2008-07-26 23:12:09 PDT
Created attachment 22498 [details] updated: remove output for DerivedSources.make Patch updated to remove --output from DerivedSources.make since it's not needed there. Renaming --output to --outputDir for Qt and Gtk build scripts.
Comment 5 Eric Seidel (no email) 2008-07-27 02:25:24 PDT
Comment on attachment 22498 [details] updated: remove output for DerivedSources.make Looks fine.