Bug 201812

Summary: REGRESSION (r243113): Leak of multiple instance variable blocks when deallocating _WKAttributedStringNavigationDelegate
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebKit APIAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, thorton, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=195636
Attachments:
Description Flags
Patch v1 none

Description David Kilzer (:ddkilzer) 2019-09-15 21:58:22 PDT
Leak of multiple instance variable blocks when deallocating _WKAttributedStringNavigationDelegate.

The _WKAttributedStringNavigationDelegate class is missing a -dealloc method under MRR.

Regressed with:

Bug 195636: Add new NSAttributedString API for converting HTML.
<https://bugs.webkit.org/show_bug.cgi?id=195636>
<https://trac.webkit.org/changeset/243113/webkit>
Comment 1 Radar WebKit Bug Importer 2019-09-15 21:58:39 PDT
<rdar://problem/55387394>
Comment 2 David Kilzer (:ddkilzer) 2019-09-15 22:02:06 PDT
Created attachment 378838 [details]
Patch v1
Comment 3 Timothy Hatcher 2019-09-16 09:04:30 PDT
Comment on attachment 378838 [details]
Patch v1

Thanks!
Comment 4 WebKit Commit Bot 2019-09-16 09:41:53 PDT
Comment on attachment 378838 [details]
Patch v1

Clearing flags on attachment: 378838

Committed r249902: <https://trac.webkit.org/changeset/249902>
Comment 5 WebKit Commit Bot 2019-09-16 09:41:54 PDT
All reviewed patches have been landed.  Closing bug.