REGRESSION (r229419): Missing call to [self init] in -[WebScrollbarPartAnimation initWithScrollbar:featureToAnimate:animateFrom:animateTo:duration:]

• Component: Scrolling
• Status: RESOLVED FIXED

[David Kilzer (:ddkilzer)]

Missing call to [self init] in -[WebScrollbarPartAnimation initWithScrollbar:featureToAnimate:animateFrom:animateTo:duration:].

- (id)initWithScrollbar:(Scrollbar*)scrollbar featureToAnimate:(FeatureToAnimate)featureToAnimate animateFrom:(CGFloat)startValue animateTo:(CGFloat)endValue duration:(NSTimeInterval)duration
{
#if !ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)
    self = [super initWithDuration:duration animationCurve:NSAnimationEaseInOut];
    if (!self)
        return nil;
#else
    // FIXME: Missing call to [self init] here!
    const NSTimeInterval timeInterval = 0.01;
    _timer = adoptNS([[NSTimer alloc] initWithFireDate:[NSDate dateWithTimeIntervalSinceNow:0] interval:timeInterval target:self selector:@selector(setCurrentProgress:) userInfo:nil repeats:YES]);
    _duration = duration;
    _timingFunction = CubicBezierTimingFunction::create(CubicBezierTimingFunction::EaseInOut);
#endif

    [...]

    return self;
}

<https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/mac/ScrollAnimatorMac.mm#L317>

[Radar WebKit Bug Importer]

<rdar://problem/55380741>

[David Kilzer (:ddkilzer)]

Created attachment 378817 [details]
Patch v1

[David Kilzer (:ddkilzer)]

Comment on attachment 378817 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=378817&action=review

> Source/WebCore/platform/mac/ScrollAnimatorMac.mm:326
> +    self = [super init];
> +    if (!self)
> +        return nil;

Note that I chose to use plain old -init due to this class inheriting from NSObject:

#if !ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)
@interface WebScrollbarPartAnimation : NSAnimation
#else
@interface WebScrollbarPartAnimation : NSObject
#endif

[WebKit Commit Bot]

Comment on attachment 378817 [details]
Patch v1

Clearing flags on attachment: 378817

Committed r249887: <https://trac.webkit.org/changeset/249887>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.