Bug 201800

Summary: [FTW] Correct lifespan of other SharedBitmaps
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, dino, don.olmstead, fujii, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2019-09-14 14:39:18 PDT
The pop-up menu code creates its own SharedBitmap in the WebContent process, which needs to release its handle before destruction, otherwise the UIProcess will be unable to access the GPU texture (since it will have been cleaned up). This patch also audits other uses of SharedBitmap to make sure a similar problem doesn't exist elsewhere.
Attachments
Patch (22.09 KB, patch)
2019-09-15 20:15 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2019-09-15 20:15:46 PDT
Created attachment 378835 [details] Patch
WebKit Commit Bot
Comment 2 2019-09-16 14:39:53 PDT
Comment on attachment 378835 [details] Patch Clearing flags on attachment: 378835 Committed r249921: <https://trac.webkit.org/changeset/249921>
WebKit Commit Bot
Comment 3 2019-09-16 14:39:54 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-09-16 14:40:16 PDT
<rdar://problem/55415000>
Note You need to log in before you can comment on or make changes to this bug.