Summary: | REGRESSION (iOS 13): rAF stops firing when navigating away cross-origin and then back | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ali Juma <ajuma> | ||||||||||||||
Component: | Animations | Assignee: | Chris Dumez <cdumez> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | cdumez, commit-queue, dino, ews-watchlist, ggaren, graouts, sabouhallawa, simon.fraser, thorton, webkit-bug-importer | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
See Also: | https://bugs.chromium.org/p/chromium/issues/detail?id=1003803 | ||||||||||||||||
Attachments: |
|
Description
Ali Juma
2019-09-13 11:55:52 PDT
Created attachment 378742 [details]
Test case
It also seems important that the URL used in Step 2 is cross-origin wrt the URL from step 1.
That suggests that it's PSON-related. Can you confirm this is with an iOS 13.1 beta? This is what I can gather from the Chromium bug but it would be nice for this bug to contain the configuration. (In reply to Antoine Quint from comment #4) > Can you confirm this is with an iOS 13.1 beta? This is what I can gather > from the Chromium bug but it would be nice for this bug to contain the > configuration. This reproduces in iOS 13.1 beta 3, but also reproduces in iOS 13.0. However, it does not reproduce in iOS 12.4. Debugging this a bit, we're stuck in a state where RenderingUpdateScheduler::isScheduled is true, but RenderingUpdateScheduler::displayRefreshFired never gets called. Ok, I can reproduce with the test case attached, thanks. I will investigate. It does not likely related to PSON although, PSON really did not change much in iOS 13. I have a fix, working on an automated test. Created attachment 378904 [details]
Patch
Comment on attachment 378904 [details]
Patch
r=me
Comment on attachment 378904 [details] Patch Attachment 378904 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13037841 New failing tests: http/tests/navigation/page-cache-requestAnimationFrame.html Created attachment 378918 [details]
Archive of layout-test-results from ews214 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews214 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment on attachment 378904 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=378904&action=review > LayoutTests/http/tests/navigation/page-cache-requestAnimationFrame.html:1 > +<!-- webkit-test-runner [ enablePageCache=true ] --> I need to add support for this to DRT so the test passes for WebKit1. Will do so before landing. Created attachment 378966 [details]
Patch
Comment on attachment 378966 [details] Patch Clearing flags on attachment: 378966 Committed r249961: <https://trac.webkit.org/changeset/249961> All reviewed patches have been landed. Closing bug. Reopening for follow-up since this introduced crashes. Created attachment 379276 [details]
Patch
Comment on attachment 379276 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379276&action=review > LayoutTests/http/tests/navigation/page-cache-requestAnimationFrame.html:42 > + }, 100); This is ... not ideal, but OK Comment on attachment 379276 [details] Patch Clearing flags on attachment: 379276 Committed r250165: <https://trac.webkit.org/changeset/250165> All reviewed patches have been landed. Closing bug. |