Bug 201761

Summary: Add release logging in WebLoaderStrategy to check that a load is going through service worker
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, cdumez, commit-queue, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2019-09-13 06:56:53 PDT
Add release logging in WebLoaderStrategy to check that a load is going through service worker
Attachments
Patch (1.94 KB, patch)
2019-09-13 06:57 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.03 KB, patch)
2019-09-14 01:55 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-09-13 06:57:49 PDT
Created attachment 378728 [details] Patch
Chris Dumez
Comment 2 2019-09-13 08:25:42 PDT
Comment on attachment 378728 [details] Patch Can we add RELEASE_LOGGING to scheduleLoadFromNetworkProcess() also? Otherwise, we cannot tell that the service worker did not handle the request and that we went to the network. It looks like we only have debug logging at the moment.
youenn fablet
Comment 3 2019-09-14 01:55:17 PDT
Created attachment 378789 [details] Patch for landing
youenn fablet
Comment 4 2019-09-14 01:56:14 PDT
(In reply to Chris Dumez from comment #2) > Comment on attachment 378728 [details] > Patch > > Can we add RELEASE_LOGGING to scheduleLoadFromNetworkProcess() also? > Otherwise, we cannot tell that the service worker did not handle the request > and that we went to the network. It looks like we only have debug logging at > the moment. I added some logging for that and made the first logging dependent on whether there is a service worker identifier in the options.
WebKit Commit Bot
Comment 5 2019-09-14 03:11:29 PDT
Comment on attachment 378789 [details] Patch for landing Clearing flags on attachment: 378789 Committed r249872: <https://trac.webkit.org/changeset/249872>
WebKit Commit Bot
Comment 6 2019-09-14 03:11:31 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-09-14 03:12:15 PDT
<rdar://problem/55364801>
Note You need to log in before you can comment on or make changes to this bug.