Bug 201728 – IndexedDB: add size estimate for keypath and other key types

• Component: New Bugs
• Status: RESOLVED DUPLICATE

[Sihui Liu]

So we can get more accurate size estimate for IDB tasks.

[Sihui Liu]

Created attachment 378661 [details]
Patch

[EWS Watchlist]

Comment on attachment 378661 [details]
Patch

Attachment 378661 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13026858

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 378673 [details]
Archive of layout-test-results from ews210 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews210  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Sihui Liu]

Created attachment 378678 [details]
Patch

[Geoffrey Garen]

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.WebCore             	0x000000010a72d8f3 WTFCrashWithInfo(int, char const*, char const*, int) + 19
1   com.apple.WebCore             	0x000000010afaf676 WebCore::encodeKey(WTF::Vector<char, 0ul, WTF::CrashOnOverflow, 16ul>&, WebCore::IDBKeyData const&) + 1318
2   com.apple.WebCore             	0x000000010afaf104 WebCore::serializeIDBKeyData(WebCore::IDBKeyData const&) + 68
3   com.apple.WebCore             	0x000000010aff8243 WebCore::IDBServer::estimateSize(WebCore::IDBKeyData const&) + 211
4   com.apple.WebCore             	0x000000010aff7998 WebCore::IDBServer::UniqueIDBDatabase::putOrAdd(WebCore::IDBRequestData const&, WebCore::IDBKeyData const&, WebCore::IDBValue const&, WebCore::IndexedDB::ObjectStoreOverwriteMode, WTF::Function<void (WebCore::IDBError const&, WebCore::IDBKeyData const&)>) + 72
5   com.apple.WebCore             	0x000000010b004930 WebCore::IDBServer::UniqueIDBDatabaseTransaction::putOrAdd(WebCore::IDBRequestData const&, WebCore::IDBKeyData const&, WebCore::IDBValue const&, WebCore::IndexedDB::ObjectStoreOverwriteMode) + 208
6   com.apple.WebCore             	0x000000010afb1d42 WebCore::IDBServer::IDBServer::putOrAdd(WebCore::IDBRequestData const&, WebCore::IDBKeyData const&, WebCore::IDBValue const&, WebCore::IndexedDB::ObjectStoreOverwriteMode) + 98
7   com.apple.WebKit              	0x000000010922e677 void IPC::handleMessage<Messages::WebIDBConnectionToClient::PutOrAdd, WebKit::WebIDBConnectionToClient, void (WebKit::WebIDBConnectionToClient::*)(WebCore::IDBRequestData const&, WebCore::IDBKeyData const&, WebCore::IDBValue const&, WebCore::IndexedDB::ObjectStoreOverwriteMode)>(IPC::Decoder&, WebKit::WebIDBConnectionToClient*, void (WebKit::WebIDBConnectionToClient::*)(WebCore::IDBRequestData const&, WebCore::IDBKeyData const&, WebCore::IDBValue const&, WebCore::IndexedDB::ObjectStoreOverwriteMode)) + 122

[Geoffrey Garen]

Comment on attachment 378678 [details]
Patch

Test crashes on EWS seem real.

[Sihui Liu]

Created attachment 378975 [details]
Patch

[Geoffrey Garen]

Comment on attachment 378975 [details]
Patch

r=me

Are we going to serialize the key again when we store it? If so, it might be nice for our caller to compute the serialized key once, and then pass it to all callees who will need it.

[Sihui Liu]

This will be fixed as part of https://bugs.webkit.org/show_bug.cgi?id=201957.

*** This bug has been marked as a duplicate of bug 201957 ***