Bug 201661

Summary: Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/getregistrations.https.html is flaky
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: Service WorkersAssignee: Chris Dumez <cdumez>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: achristensen, ap, cdumez, commit-queue, rniwa, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
URL: https://github.com/web-platform-tests/wpt/pull/19047
Attachments:
Description Flags
Patch none

Ryan Haddad
Reported 2019-09-10 15:21:19 PDT
The following layout test is flaky on Mojave Release WK2 imported/w3c/web-platform-tests/service-workers/service-worker/getregistrations.https.html Probable cause: It seems like this started after a service worker WPT update in https://trac.webkit.org/changeset/249672/webkit Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fservice-workers%2Fservice-worker%2Fgetregistrations.https.html --- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/service-workers/service-worker/getregistrations.https-expected.txt +++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/service-workers/service-worker/getregistrations.https-actual.txt @@ -1,4 +1,3 @@ - PASS registrations are not returned following unregister PASS Register then getRegistrations
Attachments
Patch (3.92 KB, patch)
2019-09-13 11:01 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-09-10 16:01:52 PDT
<rdar://problem/55240851>
Chris Dumez
Comment 2 2019-09-13 11:01:00 PDT
Created attachment 378737 [details] Patch
Alex Christensen
Comment 3 2019-09-13 11:34:16 PDT
Comment on attachment 378737 [details] Patch Are we going to upstream this?
Chris Dumez
Comment 4 2019-09-13 11:40:29 PDT
(In reply to Alex Christensen from comment #3) > Comment on attachment 378737 [details] > Patch > > Are we going to upstream this? Well, I am going to try. Maybe they can help find the root cause upstream.
Chris Dumez
Comment 5 2019-09-13 11:44:59 PDT
(In reply to Chris Dumez from comment #4) > (In reply to Alex Christensen from comment #3) > > Comment on attachment 378737 [details] > > Patch > > > > Are we going to upstream this? > > Well, I am going to try. Maybe they can help find the root cause upstream. https://github.com/web-platform-tests/wpt/pull/19047
WebKit Commit Bot
Comment 6 2019-09-13 12:17:28 PDT
Comment on attachment 378737 [details] Patch Clearing flags on attachment: 378737 Committed r249850: <https://trac.webkit.org/changeset/249850>
WebKit Commit Bot
Comment 7 2019-09-13 12:17:29 PDT
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 8 2019-09-17 14:43:21 PDT
Committed r249983: <https://trac.webkit.org/changeset/249983>
Chris Dumez
Comment 9 2019-09-17 14:43:35 PDT
Reverted in <https://trac.webkit.org/changeset/249983>.
Chris Dumez
Comment 10 2019-09-17 14:44:05 PDT
Seems to be fixed by the testharness.js updated via Bug 201843. *** This bug has been marked as a duplicate of bug 201843 ***
Note You need to log in before you can comment on or make changes to this bug.