Bug 201660

Summary:

Align our XPath API with the specification and other browsers

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

DOM

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, beidson, berto, cgarcia, commit-queue, dbates, esprehn+autocc, ews-watchlist, ggaren, gustavo, hi, joepeck, kangil.han, kondapallykalyan, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Chris Dumez

Reported 2019-09-10 15:17:30 PDT

Document.createExpression()'s first parameter should be mandatory: https://dom.spec.whatwg.org/#dom-xpathevaluatorbase-createexpression Chrome and Firefox agree with the specification.

Attachments
Patch (6.31 KB, patch) 2019-09-10 15:19 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (20.88 KB, patch) 2019-09-10 16:49 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (20.83 KB, patch) 2019-09-11 08:33 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (23.07 KB, patch) 2019-09-11 09:03 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (23.82 KB, patch) 2019-09-11 09:16 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (24.95 KB, patch) 2019-09-11 09:35 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (25.90 KB, patch) 2019-09-11 09:36 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2019-09-10 15:19:32 PDT

Created attachment 378498 [details] Patch

Chris Dumez

Comment 2 2019-09-10 16:46:07 PDT

*** Bug 201662 has been marked as a duplicate of this bug. ***

Chris Dumez

Comment 3 2019-09-10 16:49:53 PDT

Created attachment 378510 [details] Patch

Chris Dumez

Comment 4 2019-09-11 08:33:54 PDT

Created attachment 378560 [details] Patch

Chris Dumez

Comment 5 2019-09-11 09:03:47 PDT

Created attachment 378563 [details] Patch

EWS Watchlist

Comment 6 2019-09-11 09:04:15 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Chris Dumez

Comment 7 2019-09-11 09:16:39 PDT

Created attachment 378564 [details] Patch

Chris Dumez

Comment 8 2019-09-11 09:35:15 PDT

Created attachment 378567 [details] Patch

Chris Dumez

Comment 9 2019-09-11 09:36:54 PDT

Created attachment 378568 [details] Patch

Geoffrey Garen

Comment 10 2019-09-11 14:43:49 PDT

Comment on attachment 378568 [details] Patch r=me