| Summary: | setup-git-clone is using http not https | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||
| Component: | New Bugs | Assignee: | Dean Jackson <dino> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | alancoon.bugzilla, commit-queue, ews-watchlist, glenn, kocsen_chung, sam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Dean Jackson
2019-09-10 14:40:18 PDT
Created attachment 378496 [details]
Patch
Comment on attachment 378496 [details] Patch Clearing flags on attachment: 378496 Committed r249752: <https://trac.webkit.org/changeset/249752> All reviewed patches have been landed. Closing bug. This is not right. We can only do this if the git clone was also done from the HTTPS git-svn mirror. The longer explanation is that each commit message on a git-svn mirror has the annotation of the URL for the SVN commit. You may have seen this as "git-svn-id: https://svn.webkit.org/repository/webkit/trunk@r1234". Since this is embedded in the commit message and the commit message takes part in creating the hash, this makes it so that the git-svn hash of a particular revision <r1> have different hashes on the HTTP git repo, vs the HTTPS git repo. Long winded way of saying this change is currently broken given the current docs, which have us clone the http version of the git repo. (In reply to Kocsen Chung from comment #5) > This is not right. We can only do this if the git clone was also done from > the HTTPS git-svn mirror. > > > The longer explanation is that each commit message on a git-svn mirror has > the annotation of the URL for the SVN commit. You may have seen this as > "git-svn-id: https://svn.webkit.org/repository/webkit/trunk@r1234". Since > this is embedded in the commit message and the commit message takes part in > creating the hash, this makes it so that the git-svn hash of a particular > revision <r1> have different hashes on the HTTP git repo, vs the HTTPS git > repo. > > Long winded way of saying this change is currently broken given the current > docs, which have us clone the http version of the git repo. Which doc is that? Can we update the doc to clone the https version of the git repo too? Currently the docs that outline this are: - https://webkit.org/getting-the-code/ - https://trac.webkit.org/wiki/UsingGitWithWebKit I'll look into editing those instead of reverting this change. Requested change for #1. Changed #2 here: https://trac.webkit.org/wiki/UsingGitWithWebKit?action=diff&version=95 *** Bug 201206 has been marked as a duplicate of this bug. *** |