Bug 201654

Summary:

results.webkit.org: Serve files in uploaded archive

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, jbedard, slewis, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=200690

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Jonathan Bedard

Reported 2019-09-10 13:32:51 PDT

Since we have test archives uploaded to the results database, we should add an endpoint to serve the contents of those archives.

Attachments
Patch (24.35 KB, patch) 2019-09-10 13:45 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (25.45 KB, patch) 2019-09-12 17:24 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (25.03 KB, patch) 2019-09-17 15:02 PDT, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (25.12 KB, patch) 2019-12-16 14:39 PST, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (25.12 KB, patch) 2019-12-18 09:09 PST, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (25.07 KB, patch) 2019-12-18 13:09 PST, Jonathan Bedard	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Jonathan Bedard

Comment 1 2019-09-10 13:45:57 PDT

Created attachment 378482 [details] Patch

Jonathan Bedard

Comment 2 2019-09-12 17:24:18 PDT

Created attachment 378692 [details] Patch

Jonathan Bedard

Comment 3 2019-09-17 15:02:16 PDT

Created attachment 378994 [details] Patch

Jonathan Bedard

Comment 4 2019-12-16 14:39:51 PST

Created attachment 385813 [details] Patch

Jonathan Bedard

Comment 5 2019-12-16 14:45:46 PST

Originally, there were some significant performance problems with this approach, but now that we've de-duplicated archives (in https://bugs.webkit.org/show_bug.cgi?id=204860) this ends up working pretty well. It's not as fast as serving content already on disk, but it's fast enough to be usable, and it will definitely beat out our Internal buildbot instance which is under some pretty substantial load.

Jonathan Bedard

Comment 6 2019-12-18 09:09:31 PST

Created attachment 385980 [details] Patch

Stephanie Lewis

Comment 7 2019-12-18 11:00:01 PST

Comment on attachment 385980 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385980&action=review > Tools/resultsdbpy/resultsdbpy/model/archive_context.py:237 > + archive_list.append(item) So do we not want to append master to the list if it is the master?

Jonathan Bedard

Comment 8 2019-12-18 12:52:56 PST

Comment on attachment 385980 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385980&action=review >> Tools/resultsdbpy/resultsdbpy/model/archive_context.py:237 >> + archive_list.append(item) > > So do we not want to append master to the list if it is the master? Correct, we only want to append the "master" to the list once we determine that we're actually unmastered. And actually, I can even see why this worked! line 242 should also be removed.

Jonathan Bedard

Comment 9 2019-12-18 13:09:01 PST

Created attachment 385998 [details] Patch

WebKit Commit Bot

Comment 10 2019-12-18 14:22:32 PST

Comment on attachment 385998 [details] Patch Clearing flags on attachment: 385998 Committed r253721: <https://trac.webkit.org/changeset/253721>

WebKit Commit Bot

Comment 11 2019-12-18 14:22:33 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 12 2019-12-18 14:23:24 PST

<rdar://problem/58057657>

Note You need to log in before you can comment on or make changes to this bug.