Bug 201624

Summary: Web Inspector: Remove legacy CodeMirror based pretty printers
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, glenn, hi, inspector-bugzilla-changes, jer.noble, joepeck, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 201535    
Bug Blocks:    
Attachments:
Description Flags
[PATCH] Proposed Fix
hi: review+
[PATCH] For Landing
none
[PATCH] For Landing none

Joseph Pecoraro
Reported 2019-09-09 18:45:45 PDT
Remove legacy CodeMirror based pretty printers These haven't been used in a while. We already support JS/CSS formatters on a worker without CodeMirror.
Attachments
[PATCH] Proposed Fix (128.38 KB, patch)
2019-09-09 18:48 PDT, Joseph Pecoraro 		hi: review+
DetailsFormatted DiffDiff
[PATCH] For Landing (121.63 KB, patch)
2019-09-10 17:39 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] For Landing (128.25 KB, patch)
2019-09-10 17:41 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2019-09-09 18:48:53 PDT
Created attachment 378428 [details] [PATCH] Proposed Fix
Devin Rousso
Comment 2 2019-09-10 13:45:22 PDT
Comment on attachment 378428 [details] [PATCH] Proposed Fix r=me after rebase :)
Joseph Pecoraro
Comment 3 2019-09-10 16:46:34 PDT
Just waiting on the earlier patch to land.
Joseph Pecoraro
Comment 4 2019-09-10 17:36:00 PDT
Actually no need to wait for HTML Formatter. I can land this first.
Joseph Pecoraro
Comment 5 2019-09-10 17:39:19 PDT
Created attachment 378515 [details] [PATCH] For Landing
Joseph Pecoraro
Comment 6 2019-09-10 17:41:14 PDT
Created attachment 378516 [details] [PATCH] For Landing
WebKit Commit Bot
Comment 7 2019-09-10 21:01:47 PDT
Comment on attachment 378516 [details] [PATCH] For Landing Clearing flags on attachment: 378516 Committed r249751: <https://trac.webkit.org/changeset/249751>
Radar WebKit Bug Importer
Comment 8 2019-09-11 14:26:20 PDT
<rdar://problem/55276530>
Note You need to log in before you can comment on or make changes to this bug.