Bug 201624

Summary:

Web Inspector: Remove legacy CodeMirror based pretty printers

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, ews-watchlist, glenn, hi, inspector-bugzilla-changes, jer.noble, joepeck, philipj, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

201535

Bug Blocks:

Attachments:

Description	Flags
[PATCH] Proposed Fix	hi: review+
[PATCH] For Landing	none
[PATCH] For Landing	none

Description Joseph Pecoraro 2019-09-09 18:45:45 PDT

Remove legacy CodeMirror based pretty printers

These haven't been used in a while. We already support JS/CSS formatters on a worker without CodeMirror.

Comment 1 Joseph Pecoraro 2019-09-09 18:48:53 PDT

Created attachment 378428 [details]
[PATCH] Proposed Fix

Comment 2 Devin Rousso 2019-09-10 13:45:22 PDT

Comment on attachment 378428 [details]
[PATCH] Proposed Fix

r=me after rebase :)

Comment 3 Joseph Pecoraro 2019-09-10 16:46:34 PDT

Just waiting on the earlier patch to land.

Comment 4 Joseph Pecoraro 2019-09-10 17:36:00 PDT

Actually no need to wait for HTML Formatter. I can land this first.

Comment 5 Joseph Pecoraro 2019-09-10 17:39:19 PDT

Created attachment 378515 [details]
[PATCH] For Landing

Comment 6 Joseph Pecoraro 2019-09-10 17:41:14 PDT

Created attachment 378516 [details]
[PATCH] For Landing

Comment 7 WebKit Commit Bot 2019-09-10 21:01:47 PDT

Comment on attachment 378516 [details]
[PATCH] For Landing

Clearing flags on attachment: 378516

Committed r249751: <https://trac.webkit.org/changeset/249751>

Comment 8 Radar WebKit Bug Importer 2019-09-11 14:26:20 PDT

<rdar://problem/55276530>