Bug 201616 – WebKitTestRunner: Many tests timeout on macOS Catalina

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Jonathan Bedard]

When I try to run tests on macOS Catalina, hundreds of tests are timing out, mostly http tests. Many of the tests I'm seeing timeout involve ResourceLoadStatistics, although it's possible other features are also effected.

In http/tests/cache, the following tests are timing out:

    http/tests/cache/link-prefetch-main-resource-iframe.html [ Timeout ]
    http/tests/cache/link-prefetch-main-resource.html [ Timeout ]
    http/tests/cache/partitioned-cache-iframe.html [ Timeout ]
    http/tests/cache/partitioned-cache.html [ Timeout ]
    http/tests/cache/xhr-vary-header.html [ Timeout ]

[Radar WebKit Bug Importer]

<rdar://problem/55200897>

[Jonathan Bedard]

I originally thought this was because of where we were saving files, but testing today indicates that it has to do with hanging on https.

[Jonathan Bedard]

I have a pretty basic reproduction case, which took me awhile to figure out because I am still not clear on how this would happen.

In short, with http/tests/security/contentSecurityPolicy/1.1/base-uri-allow.html, the test runner is never even attempting to retrieve the other resources. This will completely break many http tests in various different ways. It doesn't seem to be apache, because I can retrieve these files fine via curl, and this test even works if I run it in the browser while the http server is running. So this would seem to be a problem in the test runner.

[Jonathan Bedard]

This is an entitlement problem:

"com.apple.WebKit(####) does not hold the necessary entitlement to delegate network traffic for other processes by pid"

[Jonathan Bedard]

Created attachment 379953 [details]
Patch

[Jonathan Bedard]

(In reply to Jonathan Bedard from comment #5)
> Created attachment 379953 [details]
> Patch

This fixes the problem...doing some additional testing, but I wanted to put the patch up for review.

[Alex Christensen]

Comment on attachment 379953 [details]
Patch

Let's keep it on for all IOS_FAMILY builds but only turn it off for open source Catalina builds.

[Jonathan Bedard]

Created attachment 379954 [details]
Patch

[Jonathan Bedard]

(In reply to Alex Christensen from comment #7)
> Comment on attachment 379953 [details]
> Patch
> 
> Let's keep it on for all IOS_FAMILY builds but only turn it off for open
> source Catalina builds.

Fair point.

[Alexey Proskuryakov]

Comment on attachment 379954 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=379954&action=review

> Source/WTF/wtf/Platform.h:1387
> +#if (PLATFORM(MAC) && defined USE_APPLE_INTERNAL_SDK && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500) || PLATFORM(IOS_FAMILY)

This should be USE(APPLE_INTERNAL_SDK), not USE_APPLE_INTERNAL_SDK.

[Jonathan Bedard]

Created attachment 379968 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 379968 [details]
Patch

Clearing flags on attachment: 379968

Committed r250590: <https://trac.webkit.org/changeset/250590>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.