Bug 201568

Summary: [WHLSL] Slim down WSLMatrix and inline constructors in native code
Product: WebKit Reporter: Saam Barati <saam>
Component: WebGPUAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, fpizlo, jonlee, justin_fan, mmaxfield, rmorisset, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch none

Description Saam Barati 2019-09-06 16:39:49 PDT
Don't call the C++ constructor. Instead, manually initialize the vector. This will allow us to remove a lot of template code which hurts compile times in boids.
Comment 1 Saam Barati 2019-09-12 13:38:51 PDT
Created attachment 378676 [details]
patch
Comment 2 Saam Barati 2019-09-12 13:53:46 PDT
Created attachment 378677 [details]
patch
Comment 3 Robin Morisset 2019-09-12 13:54:41 PDT
Comment on attachment 378677 [details]
patch

r=me
Comment 4 WebKit Commit Bot 2019-09-12 14:47:31 PDT
Comment on attachment 378677 [details]
patch

Clearing flags on attachment: 378677

Committed r249816: <https://trac.webkit.org/changeset/249816>
Comment 5 WebKit Commit Bot 2019-09-12 14:47:33 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-09-12 14:48:21 PDT
<rdar://problem/55318258>
Comment 7 Radar WebKit Bug Importer 2019-09-12 14:48:21 PDT
<rdar://problem/55318259>