Bug 201548

Summary: IndexedDB: cache prepared SQLiteStatement in SQLiteIDBCursor
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, beidson, commit-queue, ews-watchlist, ggaren, jsbell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Sihui Liu
Reported 2019-09-06 10:29:14 PDT
... so we don't need to create and compile the statement every time we use it.
Attachments
Patch (3.86 KB, patch)
2019-09-06 10:40 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2019-09-06 10:40:00 PDT
Created attachment 378204 [details] Patch
Sihui Liu
Comment 2 2019-09-09 13:43:49 PDT
This change does not make an improvement on test benchmark; but there is a small improvement on the execution time of SQLiteIDBCursor::internalFetchNextRecord when running tests like PerformanceTests/IndexedDB/basic/index-cursor-advance.html (using MonotonicTime to check the execution time).
WebKit Commit Bot
Comment 3 2019-09-10 12:42:36 PDT
Comment on attachment 378204 [details] Patch Clearing flags on attachment: 378204 Committed r249729: <https://trac.webkit.org/changeset/249729>
WebKit Commit Bot
Comment 4 2019-09-10 12:42:38 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-09-10 12:43:20 PDT
<rdar://problem/55232336>
Radar WebKit Bug Importer
Comment 6 2019-09-10 12:43:20 PDT
<rdar://problem/55232337>
Note You need to log in before you can comment on or make changes to this bug.