Bug 201525

Summary: [WHLSL] Ensure structs/arrays with pointers as fields are disallowed
Product: WebKit Reporter: Saam Barati <saam>
Component: WebGPUAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, fpizlo, jonlee, justin_fan, mmaxfield, rmorisset, ryanhaddad, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch for landing none

Saam Barati
Reported 2019-09-05 15:58:23 PDT
...
Attachments
patch (20.27 KB, patch)
2019-09-10 00:50 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch for landing (20.72 KB, patch)
2019-09-11 15:44 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2019-09-10 00:50:28 PDT
Created attachment 378445 [details] patch
Robin Morisset
Comment 2 2019-09-10 14:07:03 PDT
Comment on attachment 378445 [details] patch r=me
WebKit Commit Bot
Comment 3 2019-09-11 00:17:23 PDT
Comment on attachment 378445 [details] patch Clearing flags on attachment: 378445 Committed r249758: <https://trac.webkit.org/changeset/249758>
WebKit Commit Bot
Comment 4 2019-09-11 00:17:25 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-09-11 00:18:16 PDT
<rdar://problem/55252099>
Ryan Haddad
Comment 6 2019-09-11 09:01:39 PDT
Reverted r249758 for reason: Breaks the watchOS build. Committed r249765: <https://trac.webkit.org/changeset/249765>
Saam Barati
Comment 7 2019-09-11 14:29:27 PDT
Gonna look at the build failure now
Saam Barati
Comment 8 2019-09-11 14:29:56 PDT
(In reply to Saam Barati from comment #7) > Gonna look at the build failure now It's probably another missing include by changing the unified sources
Saam Barati
Comment 9 2019-09-11 15:44:26 PDT
Created attachment 378586 [details] patch for landing
WebKit Commit Bot
Comment 10 2019-09-11 16:34:48 PDT
Comment on attachment 378586 [details] patch for landing Clearing flags on attachment: 378586 Committed r249787: <https://trac.webkit.org/changeset/249787>
WebKit Commit Bot
Comment 11 2019-09-11 16:34:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.