Summary: | [iOS] Disabled options in the multi-select picker should not be selectable | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ken Petri <kennpetri> | ||||||
Component: | Forms | Assignee: | Aditya Keerthi <akeerthi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | akeerthi, cdumez, kris, thorton, webkit-bug-importer, wenson_hsieh | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Safari 12 | ||||||||
Hardware: | iPhone / iPad | ||||||||
OS: | iOS 12 | ||||||||
Attachments: |
|
Description
Ken Petri
2019-09-04 07:19:34 PDT
Created attachment 407321 [details]
Patch
Comment on attachment 407321 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407321&action=review > Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm:289 > + [[view titleLabel] setTextColor:[UIColor colorWithWhite:0.0 alpha:(item.isGroup) ? GroupOptionTextColorAlpha : DisabledOptionAlpha]]; Nit - I think it's a little cleaner without parentheses around item.isGroup here. > LayoutTests/fast/forms/ios/disabled-options-in-multi-select-picker.html:53 > + if (!selectElement.multiple) { Nit - we usually avoid braces around single-line if statements, even in JavaScript. > LayoutTests/fast/forms/ios/disabled-options-in-multi-select-picker.html:61 > + for (i = 0; i < element.getElementsByTagName("*").length; i++) { (Ditto) Created attachment 407324 [details]
Patch for landing
Committed r266194: <https://trac.webkit.org/changeset/266194> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407324 [details]. *** Bug 219536 has been marked as a duplicate of this bug. *** |