Bug 201441 – results.webkit.org: Fix mobile vs desktop mode

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Jonathan Bedard]

We are too aggressive about jumping into mobile mode, desktops should never ever mobile and iPad should only revert to mobile if they're in portrait mode.

[Jonathan Bedard]

Created attachment 377936 [details]
Patch

[Jonathan Bedard]

Created attachment 377990 [details]
Patch

[Zhifei Fang]

Comment on attachment 377990 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377990&action=review

> Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:108
> +@media screen and (min-device-width: 768px) {

This means we tied to the whole screen width, so on desktop, the small window browser will never trigger mobile mode, do we really want this ?

[Jonathan Bedard]

(In reply to Zhifei Fang from comment #3)
> Comment on attachment 377990 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=377990&action=review
> 
> > Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:108
> > +@media screen and (min-device-width: 768px) {
> 
> This means we tied to the whole screen width, so on desktop, the small
> window browser will never trigger mobile mode, do we really want this ?

In my opinion, yes. I kept seeing the 'mobile' mode triggering when resizing windows on my laptop. The size I needed to make the window to where I actually could have used mobile mode was so small, it wasn't really useful.

[Zhifei Fang]

(In reply to Jonathan Bedard from comment #4)
> (In reply to Zhifei Fang from comment #3)
> > Comment on attachment 377990 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=377990&action=review
> > 
> > > Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:108
> > > +@media screen and (min-device-width: 768px) {
> > 
> > This means we tied to the whole screen width, so on desktop, the small
> > window browser will never trigger mobile mode, do we really want this ?
> 
> In my opinion, yes. I kept seeing the 'mobile' mode triggering when resizing
> windows on my laptop. The size I needed to make the window to where I
> actually could have used mobile mode was so small, it wasn't really useful.

This could be wrong for iPad, for spilt screen. User may want something like this:

+-----------------+
|          |      |
|          |      |
| Desktop  |mobile|
|          |      |
|          |      |
+-----------------+

For now it seems useless because we have a long config name, however the webkit.css should design for general usage, so that when next project reuse it, it can provide those benefits.

[Jonathan Bedard]

Created attachment 378017 [details]
Patch

[Jonathan Bedard]

The newly uploaded patch removes the tablet/desktop distinction, so that except for some font sizes, tablets are treated exactly the same as desktops.

[Zhifei Fang]

unofficially r=me

[Aakash Jain]

rs=me

[Jonathan Bedard]

Created attachment 378029 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 378029 [details]
Patch for landing

Clearing flags on attachment: 378029

Committed r249506: <https://trac.webkit.org/changeset/249506>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/55048301>