Bug 201429 – REGRESSION (r249338): Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/postmessage-to-client-message-queue.https.html is a flaky failure

• Component: Service Workers
• Status: RESOLVED CONFIGURATION CHANGED

[Ryan Haddad]

The following layout test is failing on [insert platform]

imported/w3c/web-platform-tests/service-workers/service-worker/postmessage-to-client-message-queue.https.html

Probable cause:

This appears to have started with:
"Add support for postMessage buffering between the service worker and window"
https://trac.webkit.org/changeset/249338/webkit 

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fservice-workers%2Fservice-worker%2Fpostmessage-to-client-message-queue.https.html


--- /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/service-workers/service-worker/postmessage-to-client-message-queue.https-expected.txt
+++ /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/service-workers/service-worker/postmessage-to-client-message-queue.https-actual.txt
@@ -2,6 +2,6 @@
 PASS Messages from ServiceWorker to Client only received after DOMContentLoaded event. 
 PASS Messages from ServiceWorker to Client only received after calling startMessages(). 
 PASS Messages from ServiceWorker to Client only received after setting onmessage. 
-PASS Microtasks run before dispatching messages after calling startMessages(). 
-PASS Microtasks run before dispatching messages after setting onmessage. 
+FAIL Microtasks run before dispatching messages after calling startMessages(). promise_test: Unhandled rejection with value: object "Error: wait_for_state must be passed a ServiceWorker"
+FAIL Microtasks run before dispatching messages after setting onmessage. promise_test: Unhandled rejection with value: object "Error: wait_for_state must be passed a ServiceWorker"

[Radar WebKit Bug Importer]

<rdar://problem/54979900>

[Ryan Haddad]

(In reply to Ryan Haddad from comment #0)
> The following layout test is failing on [insert platform]

The test is a flaky failure on macOS Debug WK2, GTK, and WPE.

[Chris Dumez]

(In reply to Ryan Haddad from comment #2)
> (In reply to Ryan Haddad from comment #0)
> > The following layout test is failing on [insert platform]
> 
> The test is a flaky failure on macOS Debug WK2, GTK, and WPE.

Ok, it is the test I unskipped in https://trac.webkit.org/changeset/249338/webkit. I think we should mark it as flaky for now.

[Alexey Proskuryakov]

> I think we should mark it as flaky for now.

Is that really the right thing to do? r249338 implemented a feature, and the only test for it is flaky. Typically, we roll back changes like that.

[Ryan Haddad]

(In reply to Alexey Proskuryakov from comment #4)
> > I think we should mark it as flaky for now.
> 
> Is that really the right thing to do? r249338 implemented a feature, and the
> only test for it is flaky. Typically, we roll back changes like that.

Yes, I should have rolled this out. I forgot to revisit this bug.

[Ryan Haddad]

Rolled out in <https://trac.webkit.org/changeset/249615>.

[Chris Dumez]

(In reply to Ryan Haddad from comment #6)
> Rolled out in <https://trac.webkit.org/changeset/249615>.

Not sure that could not wait until Monday but ok.