Summary: | REGRESSION (r249338): Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/postmessage-to-client-message-queue.https.html is a flaky failure | ||
---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> |
Component: | Service Workers | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED CONFIGURATION CHANGED | ||
Severity: | Normal | CC: | ap, cdumez, webkit-bot-watchers-bugzilla, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | Other | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=201169 |
Description
Ryan Haddad
2019-09-03 10:17:09 PDT
(In reply to Ryan Haddad from comment #0) > The following layout test is failing on [insert platform] The test is a flaky failure on macOS Debug WK2, GTK, and WPE. (In reply to Ryan Haddad from comment #2) > (In reply to Ryan Haddad from comment #0) > > The following layout test is failing on [insert platform] > > The test is a flaky failure on macOS Debug WK2, GTK, and WPE. Ok, it is the test I unskipped in https://trac.webkit.org/changeset/249338/webkit. I think we should mark it as flaky for now. > I think we should mark it as flaky for now. Is that really the right thing to do? r249338 implemented a feature, and the only test for it is flaky. Typically, we roll back changes like that. (In reply to Alexey Proskuryakov from comment #4) > > I think we should mark it as flaky for now. > > Is that really the right thing to do? r249338 implemented a feature, and the > only test for it is flaky. Typically, we roll back changes like that. Yes, I should have rolled this out. I forgot to revisit this bug. Rolled out in <https://trac.webkit.org/changeset/249615>. (In reply to Ryan Haddad from comment #6) > Rolled out in <https://trac.webkit.org/changeset/249615>. Not sure that could not wait until Monday but ok. |