Bug 201425

Summary: REGRESSION (r249364): Layout Test webgpu/texture-triangle-strip.html is Failing
Product: WebKit Reporter: Russell Epstein <repstein>
Component: Tools / TestsAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, justin_fan, mmaxfield, repstein, ryanhaddad, sabouhallawa, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=199275
https://bugs.webkit.org/show_bug.cgi?id=201123
https://bugs.webkit.org/show_bug.cgi?id=201478
Attachments:
Description Flags
texture-triangle-strip-diff.png
none
Patch none

Description Russell Epstein 2019-09-03 09:46:21 PDT
Created attachment 377900 [details]
texture-triangle-strip-diff.png

The following layout test is failing consistently after the changes introduced in https://trac.webkit.org/changeset/249364/webkit :

webgpu/texture-triangle-strip.html

Steps to Reproduce:
The following command passes when run on r249363 and fails when run on r249364+. 
run-webkit-tests --no-retry --no-sample-on-timeout webgpu/texture-triangle-strip.html --iter 20

Test History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#tests=webgpu%2Ftexture-triangle-strip.html


Diff: See attachment.
Comment 1 Radar WebKit Bug Importer 2019-09-03 09:46:56 PDT
<rdar://problem/54978427>
Comment 2 Said Abou-Hallawa 2019-09-03 12:41:16 PDT
Created attachment 377913 [details]
Patch
Comment 3 Myles C. Maxfield 2019-09-03 16:38:23 PDT
Thanks!
Comment 4 WebKit Commit Bot 2019-09-04 01:14:54 PDT
Comment on attachment 377913 [details]
Patch

Clearing flags on attachment: 377913

Committed r249460: <https://trac.webkit.org/changeset/249460>
Comment 5 WebKit Commit Bot 2019-09-04 01:14:56 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Russell Epstein 2019-09-04 13:12:00 PDT
It looks like webgpu/viewport-scissor-rect-triangle-strip.html started failing consistently as of this patch landing ( r249460 ).
Comment 7 Said Abou-Hallawa 2019-09-04 16:42:41 PDT
Followup bug: https://bugs.webkit.org/show_bug.cgi?id=201478