Bug 201419

Summary: Use WebProcess processIdentifier to identify IDB connections between WebProcess and NetworkProcess
Product: WebKit Reporter: youenn fablet <youennf>
Component: Page LoadingAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, beidson, cdumez, commit-queue, ews-watchlist, jsbell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

youenn fablet
Reported 2019-09-03 02:52:14 PDT
Use WebProcess processIdentifier to identify IDB connections between WebProcess and NetworkProcess
Attachments
Patch (28.13 KB, patch)
2019-09-03 02:56 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (26.81 KB, patch)
2019-09-03 03:04 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (27.54 KB, patch)
2019-09-09 00:30 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-09-03 02:56:00 PDT
Created attachment 377878 [details] Patch
youenn fablet
Comment 2 2019-09-03 03:04:49 PDT
Created attachment 377881 [details] Patch
youenn fablet
Comment 3 2019-09-05 06:45:50 PDT
Comment on attachment 377881 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377881&action=review > Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp:131 > + if (auto idbConnection = m_webIDBConnectionsBySession.get(decoder.destinationID())) Will change to auto&
Alex Christensen
Comment 4 2019-09-06 10:55:11 PDT
Comment on attachment 377881 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377881&action=review > Source/WebKit/NetworkProcess/IndexedDB/WebIDBConnectionToClient.h:64 > + uint64_t identifier() const final { return m_identifier.toUInt64(); } We should eventually make this a strongly-typed identifier. > Source/WebKit/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:58 > + uint64_t messageSenderDestinationID() const final { return m_sessionID.toUInt64(); } We should eventually make this a strongly-typed identifier.
youenn fablet
Comment 5 2019-09-09 00:29:53 PDT
Comment on attachment 377881 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377881&action=review >> Source/WebKit/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:58 >> + uint64_t messageSenderDestinationID() const final { return m_sessionID.toUInt64(); } > > We should eventually make this a strongly-typed identifier. Agreed, will add a FIXME.
youenn fablet
Comment 6 2019-09-09 00:30:47 PDT
Created attachment 378351 [details] Patch for landing
WebKit Commit Bot
Comment 7 2019-09-09 02:08:46 PDT
Comment on attachment 378351 [details] Patch for landing Clearing flags on attachment: 378351 Committed r249640: <https://trac.webkit.org/changeset/249640>
WebKit Commit Bot
Comment 8 2019-09-09 02:08:47 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2019-09-09 02:09:19 PDT
<rdar://problem/55175490>
Note You need to log in before you can comment on or make changes to this bug.