Summary: | Use WebProcess processIdentifier to identify IDB connections between WebProcess and NetworkProcess | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
Component: | Page Loading | Assignee: | youenn fablet <youennf> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, alecflett, beidson, cdumez, commit-queue, ews-watchlist, jsbell, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
youenn fablet
2019-09-03 02:52:14 PDT
Created attachment 377878 [details]
Patch
Created attachment 377881 [details]
Patch
Comment on attachment 377881 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377881&action=review > Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp:131 > + if (auto idbConnection = m_webIDBConnectionsBySession.get(decoder.destinationID())) Will change to auto& Comment on attachment 377881 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377881&action=review > Source/WebKit/NetworkProcess/IndexedDB/WebIDBConnectionToClient.h:64 > + uint64_t identifier() const final { return m_identifier.toUInt64(); } We should eventually make this a strongly-typed identifier. > Source/WebKit/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:58 > + uint64_t messageSenderDestinationID() const final { return m_sessionID.toUInt64(); } We should eventually make this a strongly-typed identifier. Comment on attachment 377881 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377881&action=review >> Source/WebKit/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:58 >> + uint64_t messageSenderDestinationID() const final { return m_sessionID.toUInt64(); } > > We should eventually make this a strongly-typed identifier. Agreed, will add a FIXME. Created attachment 378351 [details]
Patch for landing
Comment on attachment 378351 [details] Patch for landing Clearing flags on attachment: 378351 Committed r249640: <https://trac.webkit.org/changeset/249640> All reviewed patches have been landed. Closing bug. |