Bug 201393

Summary: [LFC][Floats] Move FloatingState::constraints to FloatingContext
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2019-09-01 20:13:12 PDT
where it belongs.
Attachments
Patch (17.64 KB, patch)
2019-09-01 20:22 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (17.62 KB, patch)
2019-09-03 11:00 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-09-01 20:13:35 PDT
<rdar://problem/54939361>
alan
Comment 2 2019-09-01 20:22:10 PDT
Created attachment 377835 [details] Patch
Antti Koivisto
Comment 3 2019-09-03 10:09:32 PDT
Comment on attachment 377835 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377835&action=review > Source/WebCore/layout/floats/FloatingContext.cpp:287 > + for (int index = floats.size() - 1; index >= 0; --index) { for (auto index = floats.size(); --index; ) is more compact.
alan
Comment 4 2019-09-03 11:00:32 PDT
Created attachment 377908 [details] Patch
WebKit Commit Bot
Comment 5 2019-09-03 11:21:48 PDT
Comment on attachment 377908 [details] Patch Clearing flags on attachment: 377908 Committed r249433: <https://trac.webkit.org/changeset/249433>
WebKit Commit Bot
Comment 6 2019-09-03 11:21:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.