Bug 201392

Summary:

macCatalyst: Re-enable iOS WKWebView printing API

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, bdakin, megan_gardner, sam, timothy, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	wenson_hsieh: review+

Description Tim Horton 2019-09-01 16:32:51 PDT

macCatalyst: Re-enable iOS WKWebView printing API

Comment 1 Tim Horton 2019-09-01 16:33:02 PDT

Created attachment 377831 [details]
Patch

Comment 2 Tim Horton 2019-09-01 16:33:05 PDT

<rdar://problem/54690252>

Comment 3 Sam Weinig 2019-09-01 16:44:12 PDT

Comment on attachment 377831 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377831&action=review

> Source/WebKit/ChangeLog:9
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * UIProcess/API/Cocoa/WKWebView.mm:

Why? What has changed since it was disabled? Why was it disabled in the first place?

Comment 4 Tim Horton 2019-09-01 20:09:22 PDT

Because UIKit bits were missing at bringup time but have long since been introduced.

Comment 5 Tim Horton 2019-09-01 20:09:55 PDT

And “why?” -> because the API is supposed to behave identically.

Comment 6 Wenson Hsieh 2019-09-01 20:36:37 PDT

Comment on attachment 377831 [details]
Patch

r=me, with a sentence or two in the ChangeLog

Comment 7 Tim Horton 2019-09-04 12:38:03 PDT

https://trac.webkit.org/changeset/249492/webkit