Bug 201306

Summary:

Copying and pasting two paragraphs with a newline between them results in stray paragraph with newline inside

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

HTML Editing

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

Safari Technology Preview

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Timothy Hatcher

Reported 2019-08-29 12:07:05 PDT

Select all, copy and paste: Line One\nLine Two Result: Line One\nLine Two

Attachments
Patch (4.62 KB, patch) 2019-08-29 12:11 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Patch (4.60 KB, patch) 2019-08-29 12:15 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Patch (5.56 KB, patch) 2019-08-29 13:36 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Timothy Hatcher

Comment 1 2019-08-29 12:11:49 PDT Comment hidden (obsolete)

Created attachment 377604 [details] Patch

Timothy Hatcher

Comment 2 2019-08-29 12:14:44 PDT Comment hidden (obsolete)

Comment on attachment 377604 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377604&action=review > Source/WebCore/editing/ReplaceSelectionCommand.cpp:733 > + bool safeToRemoveAncestor = !ancestor.firstChild(); Oops, this was debugging code to test. Should default to true. Will post new patch.

Timothy Hatcher

Comment 3 2019-08-29 12:15:29 PDT Comment hidden (obsolete)

Created attachment 377605 [details] Patch

Wenson Hsieh

Comment 4 2019-08-29 12:31:13 PDT

Comment on attachment 377605 [details] Patch r=mews

Timothy Hatcher

Comment 5 2019-08-29 13:36:17 PDT

Created attachment 377621 [details] Patch

WebKit Commit Bot

Comment 6 2019-08-29 18:41:05 PDT

Comment on attachment 377621 [details] Patch Clearing flags on attachment: 377621 Committed r249307: <https://trac.webkit.org/changeset/249307>