Summary: | Abstract out LibWebRTCSocketClient so that rtc sockets can be implemented without libwebrtc sockets | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, commit-queue, eric.carlson, ews-watchlist, webkit-bug-importer, youennf | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
youenn fablet
2019-08-29 06:58:10 PDT
Created attachment 377579 [details]
Patch
Created attachment 377585 [details]
Patch
Comment on attachment 377585 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377585&action=review > Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp:166 > +std::unique_ptr<NetworkRTCProvider::Socket> NetworkRTCProvider::takeSocket(uint64_t identifier) A trailing return type here would remove the need for an extra NetworkRTCProvider:: > Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.h:74 > + enum class Type { UDP, ServerTCP, ClientTCP, ServerConnectionTCP }; What's the difference between "ServerTCP" and "ServerConnectionTCP"? Should "ServerTCP" be "ServerListeningTCP"? Also, these can all fit in a uint8_t. Created attachment 377828 [details]
Patch
(In reply to Alex Christensen from comment #3) > Comment on attachment 377585 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=377585&action=review > > > Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp:166 > > +std::unique_ptr<NetworkRTCProvider::Socket> NetworkRTCProvider::takeSocket(uint64_t identifier) > > A trailing return type here would remove the need for an extra > NetworkRTCProvider:: In that case I do not really mind the extra NetworkRTCProvider prefix. > > > Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.h:74 > > + enum class Type { UDP, ServerTCP, ClientTCP, ServerConnectionTCP }; > > What's the difference between "ServerTCP" and "ServerConnectionTCP"? Should > "ServerTCP" be "ServerListeningTCP"? Right, the server TCP is listening and the ServerConnectionTCP is the connection created by a TCP client. This matches more or less libwebrtc names. > Also, these can all fit in a uint8_t. OK Comment on attachment 377828 [details] Patch Clearing flags on attachment: 377828 Committed r249376: <https://trac.webkit.org/changeset/249376> All reviewed patches have been landed. Closing bug. |