Bug 201293

Summary: Address some MathML FIXMEs
Product: WebKit Reporter: Rob Buis <rbuis>
Component: MathMLAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbarton, ews-watchlist, fred.wang, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews214 for win-future
none
Patch
none
Patch none

Rob Buis
Reported 2019-08-29 01:17:52 PDT
Address some MathML FIXMEs
Attachments
Patch (4.02 KB, patch)
2019-08-29 01:20 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (9.48 KB, patch)
2019-08-29 01:55 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (14.88 KB, patch)
2019-08-29 02:51 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews214 for win-future (13.46 MB, application/zip)
2019-08-29 04:58 PDT, EWS Watchlist 		no flags
Details
Patch (11.61 KB, patch)
2019-08-29 05:30 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (11.61 KB, patch)
2019-08-29 06:51 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2019-08-29 01:20:21 PDT
Created attachment 377559 [details] Patch
Frédéric Wang Nélar
Comment 2 2019-08-29 01:32:00 PDT
Comment on attachment 377559 [details] Patch Maybe you should update foreign-element-in-token.html test accordingly?
Rob Buis
Comment 3 2019-08-29 01:55:34 PDT
Created attachment 377561 [details] Patch
Rob Buis
Comment 4 2019-08-29 01:56:00 PDT
(In reply to Frédéric Wang (:fredw) from comment #2) > Comment on attachment 377559 [details] > Patch > > Maybe you should update foreign-element-in-token.html test accordingly? Good idea, done.
Rob Buis
Comment 5 2019-08-29 02:51:26 PDT
Created attachment 377564 [details] Patch
EWS Watchlist
Comment 6 2019-08-29 04:58:45 PDT
Comment on attachment 377564 [details] Patch Attachment 377564 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12979825 New failing tests: mathml/presentation/foreign-element-in-token.html
EWS Watchlist
Comment 7 2019-08-29 04:58:47 PDT
Created attachment 377568 [details] Archive of layout-test-results from ews214 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews214 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Rob Buis
Comment 8 2019-08-29 05:30:54 PDT
Created attachment 377570 [details] Patch
WebKit Commit Bot
Comment 9 2019-08-29 06:47:55 PDT
Comment on attachment 377570 [details] Patch Rejecting attachment 377570 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 377570, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Frederic Wang found in /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: https://webkit-queues.webkit.org/results/12980124
Rob Buis
Comment 10 2019-08-29 06:51:11 PDT
Created attachment 377576 [details] Patch
WebKit Commit Bot
Comment 11 2019-08-29 07:55:02 PDT
Comment on attachment 377576 [details] Patch Clearing flags on attachment: 377576 Committed r249272: <https://trac.webkit.org/changeset/249272>
WebKit Commit Bot
Comment 12 2019-08-29 07:55:03 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 13 2019-08-29 07:56:25 PDT
<rdar://problem/54836339>
Note You need to log in before you can comment on or make changes to this bug.