Bug 201282

Summary: Remove 32-bit macOS support
Product: WebKit Reporter: Keith Rollin <krollin>
Component: WebKit Misc.Assignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, andersca, benjamin, cdumez, cmarcelo, commit-queue, darin, dbates, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=200694
Attachments:
Description Flags
Patch none

Description Keith Rollin 2019-08-28 20:46:28 PDT 
WebKit doesn’t support 32-bit Mac any more, so remove checks and code for that platform.
Comment 1 Radar WebKit Bug Importer 2019-08-28 20:46:42 PDT 
<rdar://problem/54821667>
Comment 2 Keith Rollin 2019-08-29 15:49:39 PDT 
Created attachment 377642 [details]
Patch
Comment 3 Anders Carlsson 2019-08-29 15:55:24 PDT 
Comment on attachment 377642 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=377642&action=review

> Source/JavaScriptCore/API/JSBase.h:149
>  #define JSC_OBJC_API_ENABLED 1

Does this mean that JSC_OBJC_API_ENABLED is always 1 now?
Comment 4 Keith Rollin 2019-08-29 15:58:40 PDT 
(In reply to Anders Carlsson from comment #3)
> Comment on attachment 377642 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=377642&action=review
> 
> > Source/JavaScriptCore/API/JSBase.h:149
> >  #define JSC_OBJC_API_ENABLED 1
> 
> Does this mean that JSC_OBJC_API_ENABLED is always 1 now?

It looks like it is for Cocoa. We can clean up the conditional around that in a follow-up patch.
Comment 5 WebKit Commit Bot 2019-08-29 17:39:38 PDT 
Comment on attachment 377642 [details]
Patch

Clearing flags on attachment: 377642

Committed r249304: <https://trac.webkit.org/changeset/249304>
Comment 6 WebKit Commit Bot 2019-08-29 17:39:40 PDT 
All reviewed patches have been landed.  Closing bug.