| Summary: | results.webkit.org: Move legend into sidebar | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||||||||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | aakash_jain, ap, commit-queue, repstein, tsavell, webkit-bug-importer, zhifei_fang | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Jonathan Bedard
2019-08-28 17:28:08 PDT
Created attachment 377517 [details]
Patch
Created attachment 377518 [details]
new-legend
Created attachment 377519 [details]
old-legend
I'm curious for other's thoughts on this. I think I slightly prefer the legend in the sidebar, but I could go either way. I like the idea, some feedback: If we are going to display the tray in a collapsed state, I think the legend 'bubbles' should have mouse-over tooltips to explain what they are. While not specifically related to the scope of the bug you linked, that addition makes me think we should have some way to display current branch, currently applied filters, and the results limit in a non-intrusive way instead of just the first letters of each filter option as well. I think those changes might help to justify displaying the tray in a collapsed state. Created attachment 377753 [details]
Patch
Created attachment 377760 [details]
Patch
Comment on attachment 377760 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377760&action=review > Tools/resultsdbpy/resultsdbpy/view/static/js/tooltip.js:104 > + onStateUpdate: (element, state) => { Could you change state to stateDiff ? I think this may be misleading. > Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:925 > + z-index: 50; Could you create a value for this z-index ? like middleZIndex, if in future we have more layers, this will help us to maintain. (In reply to Zhifei Fang from comment #8) > Comment on attachment 377760 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=377760&action=review > > > Tools/resultsdbpy/resultsdbpy/view/static/js/tooltip.js:104 > > + onStateUpdate: (element, state) => { > > Could you change state to stateDiff ? I think this may be misleading. > > > Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:925 > > + z-index: 50; > > Could you create a value for this z-index ? like middleZIndex, if in future > we have more layers, this will help us to maintain. unofficially r=me rs=me Created attachment 377919 [details]
Patch for landing
Comment on attachment 377919 [details] Patch for landing Clearing flags on attachment: 377919 Committed r249443: <https://trac.webkit.org/changeset/249443> All reviewed patches have been landed. Closing bug. |