Bug 201242

Summary: Fix interpretation of fraction shifts
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: MathMLAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, rbuis, rwlbuis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=201356
Bug Depends on:    
Bug Blocks: 195797    
Attachments:
Description Flags
Patch (WIP)
none
Patch
none
Patch
ews-watchlist: commit-queue-
testcase
none
screenshot of testcase with webkitgtk
none
screenshot of testcase with webkitgtk, with patch applied
none
Archive of layout-test-results from ews213 for win-future
none
Patch
none
Patch
rbuis: review+
Patch for landing
commit-queue: commit-queue-
Patch for landing none

Frédéric Wang (:fredw)
Reported 2019-08-28 15:21:11 PDT
See https://github.com/mathml-refresh/mathml/issues/123 Fraction shifts are with respect to baseline not math axis.
Attachments
Patch (WIP) (11.78 KB, patch)
2019-08-30 05:58 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Patch (11.83 KB, patch)
2019-08-30 06:14 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Patch (53.72 KB, patch)
2019-08-30 10:59 PDT, Frédéric Wang (:fredw) 		ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
testcase (1.16 KB, text/html)
2019-08-30 11:01 PDT, Frédéric Wang (:fredw) 		no flags
Details
screenshot of testcase with webkitgtk (37.27 KB, image/png)
2019-08-30 11:08 PDT, Frédéric Wang (:fredw) 		no flags
Details
screenshot of testcase with webkitgtk, with patch applied (35.78 KB, image/png)
2019-08-30 11:08 PDT, Frédéric Wang (:fredw) 		no flags
Details
Archive of layout-test-results from ews213 for win-future (13.60 MB, application/zip)
2019-08-30 12:55 PDT, EWS Watchlist 		no flags
Details
Patch (80.38 KB, patch)
2019-08-30 14:32 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Patch (80.42 KB, patch)
2019-08-30 16:24 PDT, Frédéric Wang (:fredw) 		rbuis: review+
DetailsFormatted DiffDiff
Patch for landing (80.39 KB, patch)
2019-08-31 01:15 PDT, Frédéric Wang (:fredw) 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (80.37 KB, patch)
2019-08-31 01:21 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 2 2019-08-30 05:58:34 PDT
Created attachment 377702 [details] Patch (WIP)
Frédéric Wang (:fredw)
Comment 3 2019-08-30 06:14:33 PDT
Created attachment 377703 [details] Patch There was a typo in my previous patch, this new version makes frac-parameters-1.html and frac-parameters-2.html pass again.
Frédéric Wang (:fredw)
Comment 4 2019-08-30 10:59:54 PDT
Created attachment 377728 [details] Patch
Frédéric Wang (:fredw)
Comment 5 2019-08-30 11:01:13 PDT
Created attachment 377730 [details] testcase
Frédéric Wang (:fredw)
Comment 6 2019-08-30 11:08:08 PDT
Created attachment 377731 [details] screenshot of testcase with webkitgtk
Frédéric Wang (:fredw)
Comment 7 2019-08-30 11:08:35 PDT
Created attachment 377732 [details] screenshot of testcase with webkitgtk, with patch applied
EWS Watchlist
Comment 8 2019-08-30 12:55:39 PDT
Comment on attachment 377728 [details] Patch Attachment 377728 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/12984841 New failing tests: mathml/presentation/stretchy-depth-height-symmetric.html mathml/presentation/roots.xhtml
EWS Watchlist
Comment 9 2019-08-30 12:55:45 PDT
Created attachment 377742 [details] Archive of layout-test-results from ews213 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews213 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Frédéric Wang (:fredw)
Comment 10 2019-08-30 14:32:29 PDT
Created attachment 377751 [details] Patch
Frédéric Wang (:fredw)
Comment 11 2019-08-30 16:24:06 PDT
Created attachment 377765 [details] Patch
Rob Buis
Comment 12 2019-08-31 01:11:04 PDT
Comment on attachment 377765 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377765&action=review LGTM. > LayoutTests/ChangeLog:3 > + Bug 201242 - Fix interpretation of fraction shifts No need for Bug * part. > LayoutTests/imported/w3c/ChangeLog:3 > + Bug 201242 - Fix interpretation of fraction shifts Ditto. > Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp:93 > + // See https://mathml-refresh.github.io/mathml-core/#fraction-with-nonzero-line-thickness I think comments end with period, period. > Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp:131 > + // See https://mathml-refresh.github.io/mathml-core/#fraction-with-zero-line-thickness Ditto.
Frédéric Wang (:fredw)
Comment 13 2019-08-31 01:15:53 PDT
Created attachment 377790 [details] Patch for landing
WebKit Commit Bot
Comment 14 2019-08-31 01:17:36 PDT
Comment on attachment 377790 [details] Patch for landing Rejecting attachment 377790 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 377790, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/12986844
Frédéric Wang (:fredw)
Comment 15 2019-08-31 01:21:45 PDT
Created attachment 377791 [details] Patch for landing
WebKit Commit Bot
Comment 16 2019-08-31 02:05:12 PDT
Comment on attachment 377791 [details] Patch for landing Clearing flags on attachment: 377791 Committed r249360: <https://trac.webkit.org/changeset/249360>
Radar WebKit Bug Importer
Comment 17 2019-09-04 07:11:35 PDT
<rdar://problem/55017979>
Note You need to log in before you can comment on or make changes to this bug.