| Summary: | Do not clear the pending api request when there's no navigation ID | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, commit-queue, jiewen_tan, mcatanzaro, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=200108 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 201176 | ||||||
| Attachments: |
|
||||||
|
Description
Carlos Garcia Campos
2019-08-27 01:25:12 PDT
Created attachment 377327 [details]
Patch
Comment on attachment 377327 [details] Patch Clearing flags on attachment: 377327 Committed r249142: <https://trac.webkit.org/changeset/249142> All reviewed patches have been landed. Closing bug. This caused bug #201544. (In reply to Carlos Garcia Campos from comment #0) > I've noticed that after r247851, the pending API request URL is cleared for > subresources in some cases. What did that break? (In reply to Michael Catanzaro from comment #5) > This caused bug #201544. > > (In reply to Carlos Garcia Campos from comment #0) > > I've noticed that after r247851, the pending API request URL is cleared for > > subresources in some cases. > > What did that break? See bug #200341. The thing is that when a new page starts while the previous one didn't finish, the active URL changes after webkit_kit_web_view_load_uri() and before load-failed because the pending API request URL is reset by a subresoure load of the still ongoing load. So, what happens is that load-failed reports the failing URI correctly, but the active URL is also the failing one, but it should be the new one after webkit_kit_web_view_load_uri(). I'm writing a unit test. |