Bug 201175 – Do not clear the pending api request when there's no navigation ID

• Component: WebKit2
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

I've noticed that after r247851, the pending API request URL is cleared for subresources in some cases.

[Carlos Garcia Campos]

Created attachment 377327 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 377327 [details]
Patch

Clearing flags on attachment: 377327

Committed r249142: <https://trac.webkit.org/changeset/249142>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/54749832>

[Michael Catanzaro]

This caused bug #201544.

(In reply to Carlos Garcia Campos from comment #0)
> I've noticed that after r247851, the pending API request URL is cleared for
> subresources in some cases.

What did that break?

[Carlos Garcia Campos]

(In reply to Michael Catanzaro from comment #5)
> This caused bug #201544.
> 
> (In reply to Carlos Garcia Campos from comment #0)
> > I've noticed that after r247851, the pending API request URL is cleared for
> > subresources in some cases.
> 
> What did that break?

See bug #200341. The thing is that when a new page starts while the previous one didn't finish, the active URL changes after webkit_kit_web_view_load_uri() and before load-failed because the pending API request URL is reset by a subresoure load of the still ongoing load. So, what happens is that load-failed reports the failing URI correctly, but the active URL is also the failing one, but it should be the new one after webkit_kit_web_view_load_uri(). I'm writing a unit test.